Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS intercept self-signed servers using --insecure-tls-interception #1446

Merged
merged 15 commits into from
Aug 10, 2024

Conversation

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Aug 10, 2024
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (39854e1) to head (4734c5f).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
proxy/common/utils.py 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1446      +/-   ##
===========================================
+ Coverage    84.57%   84.60%   +0.03%     
===========================================
  Files          177      178       +1     
  Lines         8103     8133      +30     
  Branches      1239     1241       +2     
===========================================
+ Hits          6853     6881      +28     
- Misses        1052     1053       +1     
- Partials       198      199       +1     
Flag Coverage Δ
GHA 84.44% <94.28%> (+0.03%) ⬆️
Linux 84.07% <94.28%> (+0.04%) ⬆️
Python 3.10 85.17% <93.10%> (+0.02%) ⬆️
Python 3.11 84.34% <94.28%> (+0.03%) ⬆️
Python 3.12 84.34% <94.28%> (+0.03%) ⬆️
Python 3.6 85.12% <93.10%> (+0.02%) ⬆️
Python 3.7 85.12% <93.10%> (+0.02%) ⬆️
Python 3.8 85.19% <93.10%> (+0.02%) ⬆️
Python 3.9 85.25% <93.10%> (+0.02%) ⬆️
Windows 78.19% <94.28%> (+0.04%) ⬆️
macOS 84.44% <94.28%> (+0.03%) ⬆️
pytest 84.44% <94.28%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinavsingh abhinavsingh changed the title Insecure TLS interception TLS intercept self-signed servers using --insecure-tls-interception Aug 10, 2024
@abhinavsingh abhinavsingh merged commit 50046d3 into develop Aug 10, 2024
58 checks passed
@abhinavsingh abhinavsingh deleted the insecure-tls-interception branch August 10, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
2 participants