Update project test dependencies to ensure green workflow #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing tutorial's link (cherry picked from commit e459f93)
abhinavsingh
added
the
bot:chronographer:skip
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…t ` tox related issues
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
abhinavsingh
commented
Apr 11, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… and bypass reverse proxy integration test result verification for now
for more information, see https://pre-commit.ci
abhinavsingh
changed the title
webknjaz
reviewed
Apr 11, 2024
| @@ -188,6 +188,7 @@ extend-ignore = | |||
| WPS613 # FIXME: unmatching super method access | |||
| WPS615 # FIXME: unpythonic setter/getter | |||
| PT027 # FIXME: use pytest.raises() instead of unittest-style 'assertRaises' | |||
| S507 # FIXME: Paramiko call with policy set to automatically trust the unknown host key | |||
There was a problem hiding this comment.
It's best to ignore such exceptions inline instead of allowing the violations globally. This way you're in control and have to review the security implications of every such place.
webknjaz
reviewed
Apr 11, 2024
Comment on lines
+7
to
+18
| # See https://github.com/yaml/pyyaml/issues/724#issuecomment-1638587228 | ||
| pyyaml==5.3.1 | ||
| # PIN to fix: | ||
| # The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; | ||
| # it therefore cannot be built with this version. | ||
| sphinxcontrib-applehelp==1.0.2 | ||
| sphinxcontrib-devhelp==1.0.2 | ||
| sphinxcontrib-htmlhelp==2.0.0 | ||
| sphinxcontrib-qthelp==1.0.3 | ||
| sphinxcontrib-serializinghtml==1.1.5 | ||
| sphinxcontrib-towncrier==0.2.1a0 | ||
| towncrier==21.3.0 |
There was a problem hiding this comment.
@abhinavsingh this change is incorrect — the .in files are supposed to only list the direct deps, not transitive, not pinned. All the pins must go to the constraint files. Otherwise, it's pointless to use separate constraint files as lockfiles as they'd contain exactly the same content with no ability to track which deps are used directly and which ones happen to be pulled in additionally.
abhinavsingh
commented
Jul 28, 2024
Comment on lines
+177
to
+180
| # FIXME: VERIFIED6 NOT ASSERTED BECAUSE WE STARTED GETTING EMPTY RESPONSE FROM UPSTREAM | ||
| # AFTER CHANGE FROM HTTPBIN TO HTTPBINGO. This test works and passes perfectly when | ||
| # run from a local system | ||
| EXIT_CODE=$(( $VERIFIED1 || $VERIFIED2 || $VERIFIED3 || $VERIFIED4 || $VERIFIED5 )) |
There was a problem hiding this comment.
This actually is a bug, identified in #1433 (comment) and fixed in #1434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.