Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test_integration on windows #1071

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sowmya-jaxl
Copy link
Contributor

  • It works reliably on local system
  • For other integration tests, we must first install openssl via choco or other methods

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Jan 27, 2022
@abhinavsingh abhinavsingh self-requested a review October 22, 2022 08:30
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #1071 (f828f4b) into develop (8b8b921) will increase coverage by 0.73%.
The diff coverage is n/a.

❗ Current head f828f4b differs from pull request most recent head f950ba9. Consider uploading reports for the commit f950ba9 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1071      +/-   ##
===========================================
+ Coverage    87.04%   87.77%   +0.73%     
===========================================
  Files          166      166              
  Lines         7025     6905     -120     
  Branches       721      693      -28     
===========================================
- Hits          6115     6061      -54     
+ Misses         780      732      -48     
+ Partials       130      112      -18     
Flag Coverage Δ
pytest 87.60% <ø> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/integration/test_integration.py 100.00% <ø> (+5.31%) ⬆️
proxy/plugin/program_name.py 33.33% <0.00%> (-0.96%) ⬇️
proxy/core/event/subscriber.py 74.41% <0.00%> (-0.30%) ⬇️
proxy/core/connection/server.py 96.66% <0.00%> (-0.11%) ⬇️
tests/test_main.py 100.00% <0.00%> (ø)
proxy/common/types.py 100.00% <0.00%> (ø)
proxy/common/utils.py 96.92% <0.00%> (ø)
proxy/core/listener/tcp.py 100.00% <0.00%> (ø)
tests/core/test_listener.py 100.00% <0.00%> (ø)
proxy/core/listener/base.py 93.93% <0.00%> (+0.60%) ⬆️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants