✨ Add new bottlerocket settings for Kubernetes settings support #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitalipaygude
changed the title
mitalipaygude
force-pushed
the
add_br_settings
branch
from
ba9c66f to
b38f4a0
Compare
mitalipaygude
force-pushed
the
add_br_settings
branch
3 times, most recently
from
6a15c09 to
5cf793f
Compare
mitalipaygude
force-pushed
the
add_br_settings
branch
from
b8cf3cf to
f26bd96
Compare
g-gaston
reviewed
Jun 10, 2024
| @@ -5,7 +5,11 @@ package bottlerocket | |||
| const ( | |||
| kubernetesInitTemplate = `{{ define "kubernetesInitSettings" -}} | |||
| [settings.kubernetes] | |||
There was a problem hiding this comment.
this is getting difficult to follow
Could we explore the option to use structs and marshal them to toml?
There was a problem hiding this comment.
|
/lgtm |
abhay-krishna
approved these changes
Jun 11, 2024
abhay-krishna
merged commit 1875473
into
abhay-krishna:eks-a-release-1.6
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for configuring the following Kubernetes settings on Bottlerocket. All settings that Bottlerocket offers here for Kubelet Configuration are added in this PR (except for serverTLSBootstrap).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #