Skip to content

Commit

Permalink
fix: build for mythirdpartylib
Browse files Browse the repository at this point in the history
  • Loading branch information
abeimler committed Jul 3, 2022
1 parent 74f66cb commit b908f19
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/libs/mythirdpartylib/include/Foo.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class MYTHIRDPARTYLIB_EXPORT Foo {
public:
Foo() = default;

/*implicit*/ Foo(int a) m_a(a) {}
/*implicit*/ Foo(int a) : m_a(a) {}

int a() const { return m_a; }

Expand Down
2 changes: 1 addition & 1 deletion test/libs/mythirdpartylib/src/Foo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ void Foo::update(bool b, bool c, bool d) {
m_a = e;
}

void Foo::bad(std::vector<string>& v) {
void Foo::bad(std::vector<std::string>& v) {
std::string val = "hello";
int index = -1; // bad, plus should use gsl::index
for (int i = 0; i < v.size(); ++i) {
Expand Down

0 comments on commit b908f19

Please sign in to comment.