reader: close channel on async read failure

abdullin · Mar 20, 2018 · b7cf4e1 · b7cf4e1
1 parent 00fd9fc
commit b7cf4e1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/reader_async.go b/reader_async.go
@@ -16,6 +16,9 @@ func (reader *Reader) ScanAsync(buffer int) chan *Rec {
 	vals := make(chan *Rec, buffer)
 
 	go func() {
+		// make sure we terminate the channel on scan read
+		defer close(vals)
+
 		err := reader.Scan(func(ri *ReaderInfo, data []byte) error {
 			vals <- &Rec{data, ri.ChunkPos, ri.StartPos, ri.NextPos}
 			return nil
@@ -24,8 +27,6 @@ func (reader *Reader) ScanAsync(buffer int) chan *Rec {
 		if err != nil {
 			log.Panic(err)
 		}
-
-		close(vals)
 	}()
 
 	return vals