Windows 10 future version - September 2018 Update

abdul99ahad · Sep 13, 2018 · 5379e10 · 5379e10
2 parents fb44423 + dca302e
commit 5379e10
Show file tree

Hide file tree

Showing 141 changed files with 3,853 additions and 1,557 deletions.
diff --git a/README.md b/README.md
@@ -543,6 +543,7 @@ For additional Windows samples, see [Windows on GitHub](http://microsoft.github.
   <td><a href="Samples/WiFiDirectServices">Wi-Fi Direct services</a></td>
  </tr>
  <tr>
+  <td><a href="Samples/HotspotAuthentication">Wi-Fi hotspot authentication</a></td>
   <td><a href="Samples/WiFiScan">Wi-Fi scanning</a></td>
  </tr>
 </table>

diff --git a/Samples/AdaptiveStreaming/cs/AdaptiveStreaming.csproj b/Samples/AdaptiveStreaming/cs/AdaptiveStreaming.csproj
@@ -136,7 +136,6 @@
       <Link>Shared\Logging\Extensions\MediaPlaybackListStringExtensions.cs</Link>
     </Compile>
     <Compile Include="Helpers\CommonLicenseRequest.cs" />
-    <Compile Include="Helpers\MediaPlayerExtensions.cs" />
     <Compile Include="Helpers\PlayReadyHelper.cs" />
     <Compile Include="Controls\ContentSelector.xaml.cs">
       <DependentUpon>ContentSelector.xaml</DependentUpon>

diff --git a/Samples/AdaptiveStreaming/cs/Helpers/MediaPlayerExtensions.cs b/Samples/AdaptiveStreaming/cs/Helpers/MediaPlayerExtensions.cs
diff --git a/Samples/AdaptiveStreaming/cs/Scenario1_SimplestAdaptiveStreaming.xaml.cs b/Samples/AdaptiveStreaming/cs/Scenario1_SimplestAdaptiveStreaming.xaml.cs
@@ -33,9 +33,6 @@ protected override void OnNavigatedFrom(NavigationEventArgs e)
             var mp = mediaPlayerElement.MediaPlayer;
             if (mp != null)
             {
-                // Explicitly disposing sources facilitates faster memory reclamation.
-                mp.DisposeSource(); // From SDKTemplate.Helpers.MediaPlayerExtensions
-
                 // Ensure MediaPlayerElement drops its reference to MediaPlayer.
                 mediaPlayerElement.SetMediaPlayer(null);
 

diff --git a/Samples/AdaptiveStreaming/cs/Scenario2_EventHandlers.xaml.cs b/Samples/AdaptiveStreaming/cs/Scenario2_EventHandlers.xaml.cs
@@ -48,7 +48,6 @@ protected override void OnNavigatedFrom(NavigationEventArgs e)
 
                 UnregisterHandlers(mediaPlayer);
 
-                mediaPlayer.DisposeSource();
                 mediaPlayerElement.SetMediaPlayer(null);
                 mediaPlayer.Dispose();
             }
@@ -133,7 +132,6 @@ private void Page_OnLoaded(object sender, RoutedEventArgs e)
         private async Task<MediaPlaybackItem> LoadSourceFromUriAsync(Uri uri, HttpClient httpClient = null)
         {
             UnregisterHandlers(mediaPlayerElement.MediaPlayer);
-            mediaPlayerElement.MediaPlayer?.DisposeSource();
 
             AdaptiveMediaSourceCreationResult result = null;
             if (httpClient != null)

diff --git a/Samples/AdaptiveStreaming/cs/Scenario3_RequestModification.xaml.cs b/Samples/AdaptiveStreaming/cs/Scenario3_RequestModification.xaml.cs
@@ -61,7 +61,6 @@ protected override void OnNavigatedFrom(NavigationEventArgs e)
 
                 UnregisterHandlers(mediaPlayer);
 
-                mediaPlayer.DisposeSource();
                 mediaPlayerElement.SetMediaPlayer(null);
                 mediaPlayer.Dispose();
             }
@@ -149,7 +148,6 @@ private void Page_OnLoaded(object sender, RoutedEventArgs e)
         private async Task<MediaPlaybackItem> LoadSourceFromUriAsync(Uri uri, HttpClient httpClient = null)
         {
             UnregisterHandlers(mediaPlayerElement.MediaPlayer);
-            mediaPlayerElement.MediaPlayer?.DisposeSource();
 
             if (tokenMethod == AzureKeyAcquisitionMethod.AuthorizationHeader)
             {

diff --git a/Samples/AdaptiveStreaming/cs/Scenario4_Tuning.xaml.cs b/Samples/AdaptiveStreaming/cs/Scenario4_Tuning.xaml.cs
@@ -55,7 +55,6 @@ protected override void OnNavigatedFrom(NavigationEventArgs e)
 
                 UnregisterHandlers(mediaPlayer);
 
-                mediaPlayer.DisposeSource();
                 mediaPlayerElement.SetMediaPlayer(null);
                 mediaPlayer.Dispose();
             }
@@ -134,7 +133,6 @@ private async void PollForInboundBitsPerSecond(CancellationTokenSource cts)
         private async Task<MediaPlaybackItem> LoadSourceFromUriAsync(Uri uri, HttpClient httpClient = null)
         {
             UnregisterHandlers(mediaPlayerElement.MediaPlayer);
-            mediaPlayerElement.MediaPlayer?.DisposeSource();
 
             AdaptiveMediaSourceCreationResult result = null;
             if (httpClient != null)

diff --git a/Samples/AdaptiveStreaming/cs/Scenario5_Metadata.xaml.cs b/Samples/AdaptiveStreaming/cs/Scenario5_Metadata.xaml.cs
@@ -50,7 +50,6 @@ protected override void OnNavigatedFrom(NavigationEventArgs e)
 
                 UnregisterHandlers(mediaPlayer);
 
-                mediaPlayer.DisposeSource();
                 mediaPlayerElement.SetMediaPlayer(null);
                 mediaPlayer.Dispose();
             }
@@ -112,7 +111,6 @@ private void Page_OnLoaded(object sender, RoutedEventArgs e)
         private async Task<MediaPlaybackItem> LoadSourceFromUriAsync(Uri uri, HttpClient httpClient = null)
         {
             UnregisterHandlers(mediaPlayerElement.MediaPlayer);
-            mediaPlayerElement.MediaPlayer?.DisposeSource();
 
             AdaptiveMediaSourceCreationResult result = null;
             if (httpClient != null)

diff --git a/Samples/AdaptiveStreaming/cs/Scenario6_AdInsertion.xaml.cs b/Samples/AdaptiveStreaming/cs/Scenario6_AdInsertion.xaml.cs
@@ -48,7 +48,6 @@ protected override void OnNavigatedFrom(NavigationEventArgs e)
 
                 UnregisterHandlers(mediaPlayer);
 
-                mediaPlayer.DisposeSource();
                 mediaPlayerElement.SetMediaPlayer(null);
                 mediaPlayer.Dispose();
             }
@@ -108,7 +107,6 @@ private void Page_OnLoaded(object sender, RoutedEventArgs e)
         private async Task<MediaPlaybackItem> LoadSourceFromUriAsync(Uri uri, HttpClient httpClient = null)
         {
             UnregisterHandlers(mediaPlayerElement.MediaPlayer);
-            mediaPlayerElement.MediaPlayer?.DisposeSource();
 
             AdaptiveMediaSourceCreationResult result = null;
             if (httpClient != null)

diff --git a/Samples/AdaptiveStreaming/cs/Scenario7_LiveSeekableRange.xaml.cs b/Samples/AdaptiveStreaming/cs/Scenario7_LiveSeekableRange.xaml.cs
@@ -52,7 +52,6 @@ protected override void OnNavigatedFrom(NavigationEventArgs e)
 
                 UnregisterHandlers(mediaPlayer);
 
-                mediaPlayer.DisposeSource();
                 mediaPlayerElement.SetMediaPlayer(null);
                 mediaPlayer.Dispose();
             }
@@ -104,7 +103,6 @@ private void Page_OnLoaded(object sender, RoutedEventArgs e)
         private async Task<MediaPlaybackItem> LoadSourceFromUriAsync(Uri uri, HttpClient httpClient = null)
         {
             UnregisterHandlers(mediaPlayerElement.MediaPlayer);
-            mediaPlayerElement.MediaPlayer?.DisposeSource();
 
             AdaptiveMediaSourceCreationResult result = null;
             if (httpClient != null)

diff --git a/Samples/BackgroundTransfer/cpp/Tasks/CompletionGroupTask.cpp b/Samples/BackgroundTransfer/cpp/Tasks/CompletionGroupTask.cpp
@@ -12,6 +12,7 @@
 #include "pch.h"
 #include "CompletionGroupTask.h"
 
+using namespace Concurrency;
 using namespace Tasks;
 using namespace Platform;
 using namespace Platform::Collections;
@@ -39,6 +40,10 @@ CompletionGroupTask::CompletionGroupTask()
 // server, or if you would like to try the transfer again with freshly updated credentials.
 void CompletionGroupTask::Run(IBackgroundTaskInstance ^ taskInstance)
 {
+    // The background task carries out asynchronous work (in RetryDownloadsAsync). Take a deferral
+    // to delay the background task from closing prematurely while the asynchronous code is still running.
+    Platform::Agile<BackgroundTaskDeferral> deferral(taskInstance->GetDeferral());
+
     BackgroundTransferCompletionGroupTriggerDetails^ details =
         dynamic_cast<BackgroundTransferCompletionGroupTriggerDetails^>(taskInstance->TriggerDetails);
 
@@ -49,33 +54,34 @@ void CompletionGroupTask::Run(IBackgroundTaskInstance ^ taskInstance)
         return;
     }
 
-    Vector<DownloadOperation^>^ badRequestDownloads = ref new Vector<DownloadOperation^>();
+    Vector<DownloadOperation^>^ failedDownloads = ref new Vector<DownloadOperation^>();
     int succeeded = 0;
     int failed = 0;
-    IVectorView<DownloadOperation^>^ downloads = details->Downloads;
-    for (IIterator<DownloadOperation^>^ iterator = downloads->First(); iterator->HasCurrent; iterator->MoveNext())
+    for (DownloadOperation^ download : details->Downloads)
     {
-        DownloadOperation^ download = iterator->Current;
-        if (Succeeded(download))
-        {
-            succeeded++;
-        }
-        else if (IsBadRequest(download))
+        if (IsFailed(download))
         {
-            badRequestDownloads->Append(download);
+            failedDownloads->Append(download);
         }
         else
         {
-            failed++;
+            succeeded++;
         }
     }
 
-    if (badRequestDownloads->Size > 0)
+    InvokeSimpleToast(succeeded, failedDownloads->Size);
+
+    if (failedDownloads->Size > 0)
     {
-        RetryDownloads(badRequestDownloads);
+        RetryDownloadsAsync(failedDownloads).then([deferral]()
+        {
+            deferral->Complete();
+        });
+    }
+    else
+    {
+        deferral->Complete();
     }
-
-    InvokeSimpleToast(succeeded, badRequestDownloads->Size, failed);
 }
 
 
@@ -108,7 +114,8 @@ BackgroundDownloader^ CompletionGroupTask::CreateBackgroundDownloader()
     return downloader;
 }
 
-bool CompletionGroupTask::Succeeded(DownloadOperation^ download)
+
+bool CompletionGroupTask::IsFailed(DownloadOperation^ download)
 {
     BackgroundTransferStatus status = download->Progress.Status;
     if (status == BackgroundTransferStatus::Error || status == BackgroundTransferStatus::Canceled)
@@ -117,55 +124,55 @@ bool CompletionGroupTask::Succeeded(DownloadOperation^ download)
     }
 
     ResponseInformation^ response = download->GetResponseInformation();
-    if (response != nullptr && response->StatusCode == 200)
+    if (response == nullptr || response->StatusCode != 200)
     {
         return true;
     }
 
     return false;
 }
 
-bool CompletionGroupTask::IsBadRequest(DownloadOperation^ download)
+task<void> CompletionGroupTask::RetryDownloadsAsync(IVector<DownloadOperation^>^ downloadsToRetry)
 {
-    ResponseInformation^ response = download->GetResponseInformation();
-    if (response != nullptr && response->StatusCode == 400)
+    BackgroundDownloader^ downloader = CompletionGroupTask::CreateBackgroundDownloader();
+    std::vector<task<void>> postRenameTasks;
+
+    for (DownloadOperation^ downloadToRetry : downloadsToRetry)
     {
-        return true;
-    }
+        // Retry with the same uri, but save to a different file name.
+        std::wstring originalName(downloadToRetry->ResultFile->Name->Data());
+        std::wstring newName = originalName.insert(originalName.find_last_of(L'.'), L"_retried");
 
-    return false;
-}
+        auto renameTask = create_task(downloadToRetry->ResultFile->RenameAsync(
+            ref new String(newName.c_str()),
+            Windows::Storage::NameCollisionOption::ReplaceExisting));
 
-void CompletionGroupTask::RetryDownloads(IIterable<DownloadOperation^>^ downloads)
-{
-    BackgroundDownloader^ downloader = CompletionGroupTask::CreateBackgroundDownloader();
+        task<void> postRenameTask = renameTask.then([downloadToRetry, downloader]()
+        {
+            DownloadOperation^ download = downloader->CreateDownload(downloadToRetry->RequestedUri, downloadToRetry->ResultFile);
 
-    for (IIterator<DownloadOperation^>^ iterator = downloads->First(); iterator->HasCurrent; iterator->MoveNext())
-    {
-        DownloadOperation^ download = iterator->Current;
-        DownloadOperation^ download2 = downloader->CreateDownload(download->RequestedUri, download->ResultFile);
-
-        // It is not necessary neither recommended to wait for completion of DownloadOperation::StartAsync() within
-        // a background task. Waiting for the completion would mean to wait until the download is complete,
-        // but that is not necessary. The download will continue executing after the background task finishes.
-        //
-        // If the a download is initiated from a background task, you need to call
-        // BackgroundDownloader::GetCurrentDownloadsAsync() when the application restarts,
-        // as demonstrated in Scenario4_CompletionGroups::AttachDownloads.
-        auto ignore = download2->StartAsync();
+            // We do not wait on background transfer asynchronous tasks, since wait will only 
+            // finish after the entire transfer is complete, which may take a very long time. 
+            // The completion of these downloads will be handled by a future CompletionGroupTask instance.
+            auto ignore = download->StartAsync();
+        });
+
+        postRenameTasks.push_back(postRenameTask);
     }
 
-    downloader->CompletionGroup->Enable();
+    return when_all(postRenameTasks.begin(), postRenameTasks.end()).then([downloader]()
+    {
+        downloader->CompletionGroup->Enable();
+    });
 }
 
-void CompletionGroupTask::InvokeSimpleToast(int succeeded, int badRequests, int failed)
+void CompletionGroupTask::InvokeSimpleToast(int succeeded, int failed)
 {
     XmlDocument^ toastXml = ToastNotificationManager::GetTemplateContent(ToastTemplateType::ToastText04);
 
     XmlNodeList^ stringElements = toastXml->GetElementsByTagName("text");
     stringElements->Item(0)->AppendChild(toastXml->CreateTextNode(succeeded.ToString() + " downloads succeeded."));
-    stringElements->Item(1)->AppendChild(toastXml->CreateTextNode(badRequests.ToString() + " downloads were bad requests, retrying."));
-    stringElements->Item(2)->AppendChild(toastXml->CreateTextNode(failed.ToString() + " downloads failed."));
+    stringElements->Item(1)->AppendChild(toastXml->CreateTextNode(failed.ToString() + " downloads failed."));
 
     ToastNotification^ toast = ref new ToastNotification(toastXml);
     ToastNotificationManager::CreateToastNotifier()->Show(toast);

diff --git a/Samples/BackgroundTransfer/cpp/Tasks/CompletionGroupTask.h b/Samples/BackgroundTransfer/cpp/Tasks/CompletionGroupTask.h
@@ -24,9 +24,9 @@ namespace Tasks
         static Windows::Networking::BackgroundTransfer::BackgroundDownloader^ CreateBackgroundDownloader();
 
     private:
-        bool Succeeded(Windows::Networking::BackgroundTransfer::DownloadOperation^ download);
-        bool IsBadRequest(Windows::Networking::BackgroundTransfer::DownloadOperation^ download);
-        void RetryDownloads(Windows::Foundation::Collections::IIterable<Windows::Networking::BackgroundTransfer::DownloadOperation^>^ downloads);
-        void InvokeSimpleToast(int succeeded, int badRequests, int failed);
+        bool IsFailed(Windows::Networking::BackgroundTransfer::DownloadOperation^ download);
+        Concurrency::task<void> RetryDownloadsAsync(
+            Windows::Foundation::Collections::IVector<Windows::Networking::BackgroundTransfer::DownloadOperation^>^ downloads);
+        void InvokeSimpleToast(int succeeded, int failed);
     };
 }