Skip to content

Commit

Permalink
fix 3 and 4
Browse files Browse the repository at this point in the history
Signed-off-by: abbyhu2000 <[email protected]>
  • Loading branch information
abbyhu2000 committed Feb 6, 2024
1 parent cea4d2f commit d68fe58
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
10 changes: 9 additions & 1 deletion test/functional/apps/dashboard/dashboard_filter_bar.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ export default function ({ getService, getPageObjects }) {
const opensearchArchiver = getService('opensearchArchiver');
const opensearchDashboardsServer = getService('opensearchDashboardsServer');
const browser = getService('browser');
const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'visualize', 'timePicker']);
const PageObjects = getPageObjects([
'common',
'dashboard',
'header',
'visualize',
'timePicker',
'discover',
]);

describe('dashboard filter bar', () => {
before(async () => {
Expand Down Expand Up @@ -191,6 +198,7 @@ export default function ({ getService, getPageObjects }) {
});

it('are added when a cell magnifying glass is clicked', async function () {
await PageObjects.discover.switchDiscoverTable('new');
await dashboardAddPanel.addSavedSearch('Rendering-Test:-saved-search');
await PageObjects.dashboard.waitForRenderComplete();

Expand Down
10 changes: 9 additions & 1 deletion test/functional/apps/dashboard/dashboard_filtering.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,14 @@ export default function ({ getService, getPageObjects }) {
const opensearchDashboardsServer = getService('opensearchDashboardsServer');
const security = getService('security');
const dashboardPanelActions = getService('dashboardPanelActions');
const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'visualize', 'timePicker']);
const PageObjects = getPageObjects([
'common',
'dashboard',
'header',
'visualize',
'timePicker',
'discover',
]);

describe('dashboard filtering', function () {
this.tags('includeFirefox');
Expand Down Expand Up @@ -182,6 +189,7 @@ export default function ({ getService, getPageObjects }) {
describe('disabling a filter unfilters the data on', function () {
before(async () => {
await filterBar.toggleFilterEnabled('bytes');
await PageObjects.discover.switchDiscoverTable('new');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
});
Expand Down

0 comments on commit d68fe58

Please sign in to comment.