Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to ignore if a container has to forcefully shutdown due to graceful shutdown not working #58

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Allow to ignore if a container has to forcefully shutdown due to graceful shutdown not working #58

merged 5 commits into from
Jan 26, 2022

Conversation

simonfrey
Copy link
Collaborator

@simonfrey simonfrey commented Jan 26, 2022 •
edited
Loading

Fixes #44 , Fixes #50

Changes proposed in this pull request:

  • Adds a ignoreFailedGracefulShutdown config parameter which skips errors for containers which are killed during shutdown
  • Ignores valid exit codes as error source (exit codes ignore 0, 143)

@simonfrey simonfrey requested a review from abahmed as a code owner January 26, 2022 10:49
abahmed
abahmed approved these changes Jan 26, 2022
View reviewed changes
Copy link
Owner

@abahmed abahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@abahmed abahmed merged commit 0694ec2 into abahmed:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abahmed abahmed abahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"kwatch detected a crash in pod" when pod is deleted normally Don't send deployment rollout notifications
2 participants
@simonfrey @abahmed