Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and deploy #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Build and deploy #33

wants to merge 3 commits into from

Conversation

deepbrook
Copy link
Contributor

As mentioned in #30, the repo could do with some automated building.

I have add this support to the .travis.yml file. I have also added the us of build stages, which makes use of concurrent execution of jobs, which may help improve the speed of CI checks.

the Deploy stage executes only for python 3.6, and creates a bdist_wheel, which I believe to be universally installable. Correct me if I'm wrong here, I'm not well read on the differences of the distributions.

In order to avoid building and pushing to pypi on every push, the conditional tags: true was added - that way, it is only built if you push a tagged commit.

The password for pypi should be encrypted using the travis CLI - since I'm guessing you won't want to share your pypi password with the world ;) see here for more information about this:
https://docs.travis-ci.com/user/deployment/pypi/

Let me know what you think!

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling fe61924 on nlsdfnbch:build-and-deploy into 9ec91cc on aayush26:master.

@aayush26
Copy link
Owner

Hi @nlsdfnbch
Extremely sorry for my super late review. Since, its christmas time(peak season), didn't get time for my personal project.
I am new to travis ci build features and needed some time to read about it also and here are my following reviews:

  1. Can you create another parallel job to lint & deploy for Python2(2.7) also?
    So, people can download version either for 2.7 or 3.6. (Let me know if any PyPi exclusive config change is required external to travis.yml)

  2. (This can be addressed later. More sort of asking for opinion on organizing and improving tests and reducing build time) Should we use different test suite for python2(2.7) and python3(3.6)?{Will improve build time by running parallely} And then use build matrix 'matrix:'? Though I am confused when to use Jobs and matrix. Already an open issue to travis-ci regarding it (jobs vs. matrix: What's the difference? travis-ci/docs-travis-ci-com#1500)
    Eg:

language: python
matrix:
  include:
  - python: "2.7"
    env: TEST_SUITE=suite_2_7
  - python: "3.6"
    env: TEST_SUITE=suite_3_6
  - python: "pypy"
    env: TEST_SUITE=suite_pypy
script: ./test.py $TEST_SUITE

Source: https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix

- "3.3"
- "3.4"
- 2.7
- 3.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, 3.6 will the released pypi package, we can remove 3.3 and add 3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants