bugfixes

osf/management/commands/monthly_reporters_go.py

@@ -58,10 +58,8 @@ def add_arguments(self, parser):
         )
 
     def handle(self, *args, **options):
-        errors = monthly_reporters_go(
+        monthly_reporters_go(
             report_year=getattr(options.get('yearmonth'), 'year', None),
             report_month=getattr(options.get('yearmonth'), 'month', None),
         )
-        for error_key, error_val in errors.items():
-            self.stdout.write(self.style.ERROR(f'error running {error_key}: ') + error_val)
-        self.stdout.write(self.style.SUCCESS('done.'))
+        self.stdout.write(self.style.SUCCESS('reporter tasks scheduled.'))

osf/metrics/reporters/_base.py

@@ -20,7 +20,7 @@ def report(
     def run_and_record_for_month(self, report_yearmonth: YearMonth) -> None:
         reports = self.report(report_yearmonth)
         for report in reports:
-            assert report.report_yearmonth == str(report_yearmonth)
+            assert str(report.report_yearmonth) == str(report_yearmonth)
             report.save()
 
 

osf/metrics/reporters/institutional_users.py

@@ -48,7 +48,11 @@ def __post_init__(self):
             user_id=self.user._id,
             user_name=self.user.fullname,
             department_name=(_affiliation.sso_department or None),
-            month_last_login=YearMonth.from_date(self.user.date_last_login),
+            month_last_login=(
+                YearMonth.from_date(self.user.date_last_login)
+                if self.user.date_last_login is not None
+                else None
+            ),
             account_creation_date=YearMonth.from_date(self.user.created),
             orcid_id=self.user.get_verified_external_id('ORCID', verified_only=True),
             public_project_count=self._public_project_queryset().count(),