Merge toolbar and action bar, change toolbar text/icons to white #21
Conversation
This minimizes wasted space. Also replace undo/redo/share icons to match android material design.
Permissions seem to work on device (needs more testing) Both internal and shared works
Icon appearance and layout About Screen is now an activity Donate button is a regular button, not fab Irrelevant menu items do not show when editorFragment is visible (sort/refresh)
While the user is typing an new Undo history entry is created when: * 1000ms pass from the last time an undo entry was created or * The user types a space * The user deletes a space
|
Hey, I like your the new look, following: random internet guy reviews your hard work. I've built snotepad with your changes, undo/redo works rather strangely. I'm not sure if it's because of your changes or if it was like this in the original app. Maybe it feels like the buttons aren't always working because they're not grayed out at the end of history? The share button doesn't do anything. You've removed the event handler when you removed the save event handler. Tested the autosave-on-keypress too, it's fast even on a long document, cool. Some rate limiting would be good for the flash memory, I guess. |
They weren't grayed out before either, and I'm intending to fix this at some point. My changes were meant to avoid having to press the button once for each character, they just group some changes together (every few seconds or every word, whichever comes first). I have been using my build (not too heavily but still) since I opened this PR and haven't noticed anything wrong with the undo, but I'll check it more thoroughly.
Noted
I can rate-limit the autosave the same way I am limiting the undo, seems like a good idea. Either way you could only lose one word or a few seconds max. I haven't seen a response from @aario so if I fix the outstanding issues and I'm happy I might decide to fork so that others can use my work. |
|
I was thinking about the same thing, after the fix for autorotate bug has not been published on F-Droid for such a long time. I don't have the capacity to manage yet another forked project alone, but if you fork it maybe make it an organization and add me? |
|
Yeah, sure. |
This minimizes wasted space. Also replace undo/redo/share icons match android material design.
I did not replace the save icon because I intend to remove the save function and replace with autosave.
I am contemplating making in configurable.