Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/lfs images for docs #543

Merged
merged 10 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
notebooks/*.ipynb -linguist-detectable
*.png filter=lfs diff=lfs merge=lfs -text
*.svg filter=lfs diff=lfs merge=lfs -text
1 change: 1 addition & 0 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
lfs: true
mdbenito marked this conversation as resolved.
Show resolved Hide resolved
- name: Setup Python 3.8
uses: ./.github/actions/python
with:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Publish Python Package to PyPI
name: Publish package and docs

on:
release:
Expand Down Expand Up @@ -29,11 +29,14 @@ jobs:
- name: Checking out last commit in release
if: ${{ github.event_name != 'workflow_dispatch' }}
uses: actions/checkout@v4
with:
lfs: true
mdbenito marked this conversation as resolved.
Show resolved Hide resolved
- name: Checking out last commit for tag ${{ inputs.tag_name }}
uses: actions/checkout@v4
if: ${{ github.event_name == 'workflow_dispatch' }}
uses: actions/checkout@v4
with:
ref: ${{ inputs.tag_name }}
lfs: true
- name: Fail if running locally
if: ${{ env.ACT }} # skip during local actions testing
run: |
Expand Down
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@

### Changed

- Improvements to documentation: fixes, links, text, example gallery and more
[PR #532](https://github.com/aai-institute/pyDVL/pull/532)
- Improvements to documentation: fixes, links, text, example gallery, LFS and
more. [PR #532](https://github.com/aai-institute/pyDVL/pull/532),
[PR #543](https://github.com/aai-institute/pyDVL/pull/543)
- Bump versions of CI actions to avoid warnings [PR #502](https://github.com/aai-institute/pyDVL/pull/502)
- Add Python Version 3.11 to supported versions [PR #510](https://github.com/aai-institute/pyDVL/pull/510)
- Documentation improvements and cleanup [PR #521](https://github.com/aai-institute/pyDVL/pull/521) [PR #522](https://github.com/aai-institute/pyDVL/pull/522)
Expand Down
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ Run the following to set up the pre-commit git hook to run before pushes:
pre-commit install --hook-type pre-push
```

Additionally, we use Git LFS for some files like images. Install with

```shell
git lfs install
```

## Setting up your environment

We strongly suggest using some form of virtual environment for working with the
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pyDVL focuses on model-dependent methods.
width="70%"
align="center"
style="display: block; margin-left: auto; margin-right: auto;"
src="https://raw.githubusercontent.com/aai-institute/pyDVL/develop/docs/value/img/mclc-best-removal-10k-natural.svg"
src="https://pydvl.org/devel/value/img/mclc-best-removal-10k-natural.svg"
alt="best sample removal"
/>
<p align="center" style="text-align:center;">
Expand All @@ -51,7 +51,7 @@ of training samples over individual test points.
width="70%"
align="center"
style="display: block; margin-left: auto; margin-right: auto;"
src="https://raw.githubusercontent.com/aai-institute/pyDVL/develop/docs/assets/influence_functions_example.png"
src="https://pydvl.org/devel/examples/img/influence_functions_example.png"
alt="best sample removal"
/>
<p align="center" style="text-align:center;">
Expand Down
68,004 changes: 3 additions & 68,001 deletions ...l/value/shapley/classwise/img/classwise-shapley-discounted-utility-function.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/assets/logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/assets/material-code.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/assets/material-computer.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/assets/material-description.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/assets/material-toolbox.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/assets/signet.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
18 changes: 9 additions & 9 deletions docs/examples/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ alias:
An introduction using the spotify dataset, showcasing grouped datasets and
applied to improving model performance and identifying bogus data.

[![](/assets/shapley_basic_spotify.png)](shapley_basic_spotify/)
[![](img/shapley_basic_spotify.png)](shapley_basic_spotify/)

- [__KNN Shapley__](shapley_knn_flowers/)

---

A showcase of a fast model-specific valuation method using the iris dataset.

[![](/assets/shapley_knn_flowers.png)](shapley_knn_flowers/)
[![](img/shapley_knn_flowers.png)](shapley_knn_flowers/)

- [__Data utility learning__](shapley_utility_learning/)

Expand All @@ -33,7 +33,7 @@ alias:
Learning a utility function from a few evaluations and using it to estimate
the value of the remaining data.

[![](/assets/shapley_utility_learning.png)](shapley_utility_learning/)
[![](img/shapley_utility_learning.png)](shapley_utility_learning/)

- [__Least Core__](least_core_basic/)

Expand All @@ -42,7 +42,7 @@ alias:
An alternative solution concept from game theory, illustrated on a
classification problem.

[![](/assets/least_core_basic.png)](least_core_basic/)
[![](img/least_core_basic.png)](least_core_basic/)

- [__Data OOB__](data_oob/)

Expand All @@ -51,7 +51,7 @@ alias:
A different and fast strategy for data valuation, using the out-of-bag
error of a bagging model.

[![](/assets/data_oob.png)](data_oob/)
[![](img/data_oob.png)](data_oob/)

</div>

Expand All @@ -66,31 +66,31 @@ alias:

Detecting corrupted labels with influence functions on the ImageNet dataset.

[![](/assets/influence_imagenet.png)](influence_imagenet/)
[![](img/influence_imagenet.png)](influence_imagenet/)

- [__For language models__](influence_sentiment_analysis/)

---

Using the IMDB dataset for sentiment analysis and a fine-tuned BERT model.

[![](/assets/influence_sentiment_analysis.png)](influence_sentiment_analysis/)
[![](img/influence_sentiment_analysis.png)](influence_sentiment_analysis/)

- [__For mislabeled data__](influence_synthetic/)

---

Detecting corrupted labels using a synthetic dataset.

[![](/assets/influence_functions_example.png)](influence_synthetic/)
[![](img/influence_functions_example.png)](influence_synthetic/)

- [__For outlier detection__](influence_wine/)

---

Using the wine dataset

[![](/assets/influence_wine.png)](influence_wine/)
[![](img/influence_wine.png)](influence_wine/)


</div>
4 changes: 3 additions & 1 deletion docs/value/img/classwise-shapley-density.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/value/img/classwise-shapley-metric-auc-cv.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/value/img/classwise-shapley-metric-auc-mean.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/value/img/classwise-shapley-metric-wad-cv.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/value/img/classwise-shapley-metric-wad-mean.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/value/img/mclc-best-removal-10k-natural.svg

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion docs/value/img/mclc-worst-removal-10k-natural.svg

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions docs/value/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ alias:
# Data valuation

!!! Info
If you want to jump right into the steps to compute values, skip ahead
to [[computing-data-values]]. If you want a quick list of applications, see
[[data-valuation-applications]]. For a list of all algorithms implemented in
pyDVL, see [[methods]].
If you want to jump right into it, skip ahead to [Computing data
values][computing-data-values]. If you want a quick list of applications,
see [[data-valuation-applications]]. For a list of all algorithms
implemented in pyDVL, see [[methods]].

**Data valuation** is the task of assigning a number to each element of a
training set which reflects its contribution to the final performance of some
Expand Down
Loading
Loading