Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to github action for freeing disk space #526

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

schroedk
Copy link
Collaborator

@schroedk schroedk commented Mar 20, 2024

Description

This closes #528

Changes

  • free disk space before running tests

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@schroedk schroedk requested a review from AnesBenmerzoug March 20, 2024 14:42
@AnesBenmerzoug
Copy link
Collaborator

The step is supposed to run by default? If yes, then I don't know why it is skipped in CI.

@schroedk
Copy link
Collaborator Author

The step is supposed to run by default? If yes, then I don't know why it is skipped in CI.

That is strange, indeed

@schroedk schroedk merged commit 347ccdc into develop Mar 20, 2024
23 checks passed
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
with:
large-packages: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schroedk Wouldn't it be better to remove android support (14GB) than large-packages (5GB)?

Also, among the large packages might be some for image processing, which are required for a new plugin in mkdocs. Although this only runs in tests, someone might be tempted to copy paste the step at some point.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdbenito android is removed by default, ... : false means exclude it from cleaning. So large-packages are excluded from cleaning.

@mdbenito mdbenito deleted the fix/free-disk-space branch March 22, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No space left on device, github actions
3 participants