Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tolerate fixture to separate repository #539

Closed
AnesBenmerzoug opened this issue Mar 23, 2024 · 2 comments · Fixed by #558
Closed

Move tolerate fixture to separate repository #539

AnesBenmerzoug opened this issue Mar 23, 2024 · 2 comments · Fixed by #558
Assignees
Labels
cleanup when code is ugly or unreadable and needs restyling utils
Milestone

Comments

@AnesBenmerzoug
Copy link
Collaborator

With the changes in #529, we no longer use the tolerate fixture and we should therefore remove it from the repository. However I think it is useful and there may be other uses for it beyond pyDVL. Therefore I suggest we move it a separate repository and open-source it.

All the related code can be found in tests/tolerate.py and tests/conftest.py.

We should refer to pytest's documentation for instructions on how to create a plugin.

It turns out that there is a similar plugin called pytest-repeat that allows repeating tests on failure. However our implementation allows setting the number of repetitions inside a test's function. We could contribute that change to that other plugin but that would take longer and would involve a lot more communication overhead.

@AnesBenmerzoug AnesBenmerzoug added utils cleanup when code is ugly or unreadable and needs restyling labels Mar 23, 2024
@AnesBenmerzoug AnesBenmerzoug added this to the v0.10.0 milestone Mar 23, 2024
@AnesBenmerzoug AnesBenmerzoug self-assigned this Mar 23, 2024
@AnesBenmerzoug
Copy link
Collaborator Author

After a bit of search I found that there already exists a pytest plugin call pytest-rerunfailures that reruns tests on failure. We should perhaps removing our code and use that instead.

@mdbenito
Copy link
Collaborator

mdbenito commented May 28, 2024 via email

This was referenced Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup when code is ugly or unreadable and needs restyling utils
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants