-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Parallel Backend #529
Conversation
The test was fickle to begin with and now it started failing for no reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Simple is always better 👍🏽 I left a few minor comments and a few questions. Maybe we can talk on Monday about how the final usage pattern will look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍🏽
Description
This PR closes #360 #535 #536 and addresses part of #385
Changes
parallel_config
context manager.ParallelConfig
except forbackend
in preparation for removing it altogether in favour of letting the user instantiate the parallel backend instance and passing it to the method.Checklist
If notebooks were added/changed, added boilerplate cells are tagged with"tags": ["hide"]
or"tags": ["hide-input"]