Deactivate test case and add TODO

aai-institute · Sep 1, 2023 · c28ce5e · c28ce5e
1 parent 4e889f7
commit c28ce5e
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/tests/value/shapley/test_montecarlo.py b/tests/value/shapley/test_montecarlo.py
@@ -75,19 +75,14 @@ def test_analytic_montecarlo_shapley(
 test_cases_montecarlo_shapley_reproducible_stochastic = [
     # TODO Add once issue #416 is closed.
     # (12, ShapleyMode.PermutationMontecarlo, {"done": MaxChecks(1)}),
-    # # FIXME! it should be enough with 2**(len(data)-1) samples
-    # (
-    #     8,
-    #     ShapleyMode.CombinatorialMontecarlo,
-    #     {"done": MaxChecks(1)},
-    # ),
-    (12, ShapleyMode.Owen, dict(n_samples=4, max_q=200)),
-    (12, ShapleyMode.OwenAntithetic, dict(n_samples=4, max_q=200)),
     (
-        4,
-        ShapleyMode.GroupTesting,
-        dict(n_samples=int(21), epsilon=0.2, delta=0.01),
+        12,
+        ShapleyMode.CombinatorialMontecarlo,
+        {"done": MaxChecks(4)},
     ),
+    (12, ShapleyMode.Owen, dict(n_samples=4, max_q=200)),
+    (12, ShapleyMode.OwenAntithetic, dict(n_samples=4, max_q=200)),
+    (4, ShapleyMode.GroupTesting, dict(n_samples=int(21), epsilon=0.2, delta=0.01)),
 ]