Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property of progress indicator's background image #34

Closed
wants to merge 2 commits into from

Conversation

YuyaAbo
Copy link

@YuyaAbo YuyaAbo commented Oct 27, 2019

referred issue #14

add backgroundImage property at LiquidPullToRefresh.

Sample

# example/lib/main.dart
~~~
body: LiquidPullToRefresh(
        key: _refreshIndicatorKey,
        onRefresh: _handleRefresh,
+       backgroundImage: Image.network("http://placehold.jp/150x150.png").image,
~~~

I would be happy if you could check it. 🙏

@codecov
Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #34 into master will decrease coverage by 0.32%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   86.06%   85.74%   -0.33%     
==========================================
  Files           3        3              
  Lines         445      449       +4     
==========================================
+ Hits          383      385       +2     
- Misses         62       64       +2     
Impacted Files Coverage Δ
lib/src/circular_progress.dart 87.50% <33.33%> (-3.62%) ⬇️
lib/liquid_pull_to_refresh.dart 87.98% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ed32a...f5f4b5b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants