Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aspd buffing v2 #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix aspd buffing v2 #19

wants to merge 2 commits into from

Commits on Aug 2, 2021

  1. A more efficient fix for aspd buffs. 

    This uses the same approach as the v1 fix, but checks a variable set directly on the unit itself instead of checking a global table.

Manually set the can_use_aspd variable to true in each unit section in Player:init, where the unit has a timed action with tag 'shoot' or 'attack'.
    @cmaligec
    cmaligec committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    509c552 View commit details
    Browse the repository at this point in the history

  2. Modified the cooldown draw code in arena.lua. 

    Similar to the aspd buff changes, the draw code now checks a variable set directly on the unit, instead of going through a table.

Manually added the has_cooldown variable to each appropriate unit section in Player:init. Also removed the non_cooldown_characters table from main.lua, as the only place that uses it has been modified in a way that no longer needs it.

Note: Even though the pyromancer and cryomancer do damage on a timer, it is handled by the DotArea code and so the variables needed to fill their charge bar never get set. These are the only two characters that exclussively attack through dot damage routines. For both, the cooldown flags were left false by default. Originally they were left out from the list of non_cooldown_characters.
    @cmaligec
    cmaligec committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    078f915 View commit details
    Browse the repository at this point in the history