修复大并发抛异常的根本原因

a2888409 · Apr 21, 2016 · ccddbf0 · ccddbf0
1 parent 550a1d7
commit ccddbf0
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/protobuf/src/main/java/protobuf/code/PacketDecoder.java b/protobuf/src/main/java/protobuf/code/PacketDecoder.java
@@ -37,7 +37,7 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf in,
             return;
         }
 
-        if (length > in.readableBytes()) {
+        if (length > in.readableBytes() - 4) {
             //注意！编解码器加这种in.readInt()日志，在大并发的情况下很可能会抛数组越界异常！
             //logger.error("message received is incomplete,ptoNum:{}, length:{}, readable:{}", in.readInt(), length, in.readableBytes());
             in.resetReaderIndex();
@@ -46,11 +46,6 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf in,
 
         int ptoNum = in.readInt();
 
-        //此处大并发的时候可能会抛出异常再检查一次
-        if (length > in.readableBytes()) {
-            in.resetReaderIndex();
-            return;
-        }
 
         ByteBuf byteBuf = Unpooled.buffer(length);