Refactor doc and Fix some devops bug (DataLinkDC#2826)

* Optimization The data source directory tree has two scroll bars * [Improvement-2809] Improvement result not scroll (DataLinkDC#2819) * improve-result-scroll * Spotless Apply --------- Co-authored-by: Zzm0809 <[email protected]> * refactor docs and fix some bug * Spotless Apply * added devops docs * modify alert_strategy.md * fix render bug * fix NPE * fix debug bug --------- Co-authored-by: Zzm0809 <[email protected]>
Zzm0809 · Dec 27, 2023 · cdec3e0 · cdec3e0
1 parent b3f5fa5
commit cdec3e0
Show file tree

Hide file tree

Showing 47 changed files with 346 additions and 3,893 deletions.
diff --git a/README.md b/README.md
@@ -148,3 +148,8 @@ Thanks to [JetBrains](https://www.jetbrains.com/?from=dlink) for providing a fre
 
 Please refer to the [LICENSE](https://github.com/DataLinkDC/dinky/blob/dev/LICENSE) document.
 
+# Contributors
+
+<a href="https://github.com/DataLinkDC/dinky/graphs/contributors">
+  <img src="https://contrib.rocks/image?repo=DataLinkDC/dinky" />
+</a>
diff --git a/README_zh_CN.md b/README_zh_CN.md
@@ -148,4 +148,10 @@ Dinky 是一个 `开箱即用` 、`易扩展` ，以 `Apache Flink` 为基础，
 
 ## 版权
 
-请参考 [LICENSE](https://github.com/DataLinkDC/dinky/blob/dev/LICENSE) 文件。
+请参考 [LICENSE](https://github.com/DataLinkDC/dinky/blob/dev/LICENSE) 文件。
+
+# 贡献者
+
+<a href="https://github.com/DataLinkDC/dinky/graphs/contributors">
+  <img src="https://contrib.rocks/image?repo=DataLinkDC/dinky" />
+</a>
diff --git a/dinky-admin/src/main/java/org/dinky/service/impl/TaskServiceImpl.java b/dinky-admin/src/main/java/org/dinky/service/impl/TaskServiceImpl.java
@@ -511,14 +511,21 @@ public boolean changeTaskLifeRecyle(Integer taskId, JobLifeCycle lifeCycle) thro
         boolean saved = saveOrUpdate(task.buildTask());
         if (saved && Asserts.isNotNull(task.getJobInstanceId())) {
             JobInstance jobInstance = jobInstanceService.getById(task.getJobInstanceId());
-            jobInstance.setStep(lifeCycle.getValue());
-            jobInstanceService.updateById(jobInstance);
-            log.info("jobInstance [{}] step change to {}", jobInstance.getJid(), lifeCycle.getValue());
+            if (Asserts.isNotNull(jobInstance)) {
+                jobInstance.setStep(lifeCycle.getValue());
+                boolean updatedJobInstance = jobInstanceService.updateById(jobInstance);
+                if (updatedJobInstance) jobInstanceService.refreshJobInfoDetail(jobInstance.getId(), true);
+                log.warn(
+                        "JobInstance [{}] step change to [{}] ,Trigger Force Refresh",
+                        jobInstance.getName(),
+                        lifeCycle.getValue());
+            }
         }
         return saved;
     }
 
     @Override
+    @Transactional(rollbackFor = Exception.class)
     public boolean saveOrUpdateTask(Task task) {
         Task byId = getById(task.getId());
         if (byId != null && JobLifeCycle.PUBLISH.equalsValue(byId.getStep())) {

diff --git a/dinky-web/src/pages/DataStudio/LeftContainer/Project/function.tsx b/dinky-web/src/pages/DataStudio/LeftContainer/Project/function.tsx
@@ -80,19 +80,19 @@ export const buildStepValue = (step: number) => {
       return {
         title: l('global.table.lifecycle.dev'),
         status: 'processing',
-        color: '#1890ff'
+        color: 'cyan'
       };
     case 2:
       return {
         title: l('global.table.lifecycle.online'),
         status: 'success',
-        color: '#52c41a'
+        color: 'purple'
       };
     default:
       return {
         title: l('global.table.lifecycle.dev'),
         status: 'default',
-        color: '#1890ff'
+        color: 'cyan'
       };
   }
 };
@@ -144,7 +144,8 @@ export const buildProjectTree = (
           <>
             <Badge
               title={stepValue.title}
-              status={(stepValue.status as PresetStatusColorType) ?? 'default'}
+              color={stepValue.color}
+              // status={(stepValue.status as PresetStatusColorType) ?? 'default'}
             />
           </>
         );

diff --git a/dinky-web/src/pages/DevOps/JobDetail/JobOverview/components/FlinkTable.tsx b/dinky-web/src/pages/DevOps/JobDetail/JobOverview/components/FlinkTable.tsx
@@ -19,7 +19,12 @@
 
 import StatusTag from '@/components/JobTags/StatusTag';
 import { JobProps } from '@/pages/DevOps/JobDetail/data';
-import { parseByteStr, parseMilliSecondStr, parseNumStr } from '@/utils/function';
+import {
+  formatTimestampToYYYYMMDDHHMMSS,
+  parseByteStr,
+  parseMilliSecondStr,
+  parseNumStr
+} from '@/utils/function';
 import { l } from '@/utils/intl';
 import { ProCard, ProColumns, ProTable } from '@ant-design/pro-components';
 import { Typography } from 'antd';
@@ -32,8 +37,10 @@ export type VerticesTableListItem = {
   metrics: any;
   parallelism: number;
   startTime?: number;
+  'start-time'?: number;
   duration?: number;
   endTime?: number;
+  'end-time'?: number;
   tasks: any;
 };
 
@@ -101,15 +108,20 @@ const FlinkTable = (props: JobProps): JSX.Element => {
     },
     {
       title: l('global.table.startTime'),
-      dataIndex: 'startTime',
-      valueType: 'dateTime'
+      render: (dom, entity) => {
+        return entity.startTime === -1 || entity['start-time'] === -1
+          ? '-'
+          : formatTimestampToYYYYMMDDHHMMSS(entity['start-time'] as number) ||
+              formatTimestampToYYYYMMDDHHMMSS(entity.startTime as number);
+      }
     },
     {
       title: l('global.table.endTime'),
-      dataIndex: 'endTime',
-      valueType: 'dateTime',
       render: (dom, entity) => {
-        return entity.endTime === -1 ? '-' : entity.endTime;
+        return entity.endTime === -1 || entity['end-time'] === -1
+          ? '-'
+          : formatTimestampToYYYYMMDDHHMMSS(entity['end-time'] as number) ||
+              formatTimestampToYYYYMMDDHHMMSS(entity.endTime as number);
       }
     },
     {

diff --git a/dinky-web/src/pages/DevOps/JobDetail/JobOverview/components/JobDesc.tsx b/dinky-web/src/pages/DevOps/JobDetail/JobOverview/components/JobDesc.tsx
@@ -88,7 +88,7 @@ const JobDesc = (props: JobProps) => {
 
           <Descriptions.Item label={l('devops.jobinfo.config.RestartStrategy')}>
             <Tag color='blue' title={'Restart Strategy'}>
-              {jobDetail?.jobDataDto?.config?.executionConfig?.restartStrategy}
+              {jobDetail?.jobDataDto?.config['execution-config']['restart-strategy']}
             </Tag>
           </Descriptions.Item>
 
@@ -109,13 +109,11 @@ const JobDesc = (props: JobProps) => {
           </Descriptions.Item>
 
           <Descriptions.Item label={l('devops.jobinfo.config.useSqlFragment')}>
-            {jobDetail?.history?.configJson?.useSqlFragment
-              ? l('button.enable')
-              : l('button.disable')}
+            {jobDetail?.history?.configJson?.fragment ? l('button.enable') : l('button.disable')}
           </Descriptions.Item>
 
           <Descriptions.Item label={l('devops.jobinfo.config.execmode')}>
-            {jobDetail?.history?.configJson?.useBatchModel
+            {jobDetail?.history?.configJson?.batchModel
               ? l('global.table.execmode.batch')
               : l('global.table.execmode.streaming')}
           </Descriptions.Item>
@@ -125,7 +123,7 @@ const JobDesc = (props: JobProps) => {
           </Descriptions.Item>
 
           <Descriptions.Item label={l('devops.jobinfo.config.JobParallelism')}>
-            {jobDetail?.jobDataDto?.config?.executionConfig?.jobParallelism}
+            {jobDetail?.jobDataDto?.config['execution-config']['job-parallelism']}
           </Descriptions.Item>
 
           <Descriptions.Item label={l('global.table.useTime')}>
@@ -137,7 +135,7 @@ const JobDesc = (props: JobProps) => {
           </Descriptions.Item>
 
           <Descriptions.Item label={l('devops.jobinfo.config.savePointPath')} span={2}>
-            {jobDetail?.history?.configJson.savePointPath}
+            {jobDetail?.history?.configJson?.configJson['state.savepoints.dir'] ?? '-'}
           </Descriptions.Item>
         </Descriptions>
       </ProCard>

diff --git a/dinky-web/src/pages/DevOps/JobDetail/index.tsx b/dinky-web/src/pages/DevOps/JobDetail/index.tsx
@@ -65,7 +65,7 @@ const JobDetail = (props: any) => {
     pollingInterval: 3000
   });
 
-  const jobInfoDetail: Jobs.JobInfoDetail = data;
+  const jobInfoDetail = data as Jobs.JobInfoDetail;
 
   const [tabKey, setTabKey] = useState<string>(OperatorEnum.JOB_BASE_INFO);
 

diff --git a/dinky-web/src/types/DevOps/data.d.ts b/dinky-web/src/types/DevOps/data.d.ts
@@ -18,7 +18,7 @@
  */
 
 import { BaseBeanColumns } from '@/types/Public/data';
-import { Alert } from '@/types/RegCenter/data.d';
+import { Alert, Cluster } from '@/types/RegCenter/data.d';
 
 /**
  * about flink job
@@ -48,6 +48,62 @@ declare namespace Jobs {
     useBatchModel: string;
   };
 
+  export type ExecutorSetting = {
+    type: string;
+    host: string;
+    port: number;
+    useBatchModel: boolean;
+    checkpoint: string;
+    parallelism: number;
+    useSqlFragment: boolean;
+    useStatementSet: boolean;
+    savePointPath: string;
+    jobName: string;
+    config: Map<string, string>;
+    variables: Map<string, string>;
+    jarFiles: [];
+    jobManagerAddress: string;
+    plan: boolean;
+    remote: boolean;
+    validParallelism: boolean;
+    validJobName: boolean;
+    validHost: boolean;
+    validPort: boolean;
+    validConfig: boolean;
+    validVariables: boolean;
+    validJarFiles: boolean;
+  };
+
+  export type JobConfigJsonInfo = {
+    type: string;
+    checkpoint: string;
+    savePointStrategy: string;
+    savePointPath: string;
+    parallelism: number;
+    clusterId: number;
+    clusterConfigurationId: number;
+    step: number;
+    configJson: {
+      'state.savepoints.dir': string;
+    };
+    useResult: boolean;
+    useChangeLog: boolean;
+    useAutoCancel: boolean;
+    useRemote: boolean;
+    address: string;
+    taskId: number;
+    jarFiles: [];
+    pyFiles: [];
+    jobName: string;
+    fragment: boolean;
+    statementSet: boolean;
+    batchModel: boolean;
+    maxRowNum: number;
+    gatewayConfig: any;
+    variables: Map<string, string>;
+    executorSetting: ExecutorSetting;
+  };
+
   export type History = {
     id: number;
     tenantId: number;
@@ -61,7 +117,7 @@ declare namespace Jobs {
     type: string;
     error: string;
     result: string;
-    configJson: JobConfig;
+    configJson: JobConfigJsonInfo;
     startTime: string;
     endTime: string;
     taskId: number;
@@ -166,13 +222,18 @@ declare namespace Jobs {
     jid: string;
     name: string;
     executionConfig: ExecutionConfig;
+    'execution-config': ExecutionConfig;
   };
   export type ExecutionConfig = {
     executionMode: string;
+    'execution-mode': string;
     restartStrategy: string;
+    'restart-strategy': string;
     jobParallelism: number;
-    objectReuse: boolean;
+    'job-parallelism': number;
+    'object-reuse': boolean;
     userConfig: any;
+    'user-config': any;
   };
 
   export type JobDataDtoItem = {
@@ -191,8 +252,8 @@ declare namespace Jobs {
   export type JobInfoDetail = {
     id: number;
     instance: JobInstance;
-    clusterInstance: any;
-    clusterConfiguration: any;
+    clusterInstance: Cluster.Instance;
+    clusterConfiguration: Cluster.Config;
     history: History;
     jobDataDto: JobDataDtoItem;
     jobManagerConfiguration: any;

diff --git a/dinky-web/src/utils/function.tsx b/dinky-web/src/utils/function.tsx
@@ -45,7 +45,6 @@ import { l } from '@/utils/intl';
 import { Monaco } from '@monaco-editor/react';
 import dayjs from 'dayjs';
 import cookies from 'js-cookie';
-import { trim } from 'lodash';
 import { editor, KeyCode, KeyMod } from 'monaco-editor';
 import path from 'path';
 import { format } from 'sql-formatter';
@@ -619,6 +618,13 @@ export const formatDateToYYYYMMDDHHMMSS = (date: Date) => {
   return dayjs(date).format(DATETIME_FORMAT);
 };
 
+export const formatTimestampToYYYYMMDDHHMMSS = (timestamp: number) => {
+  if (timestamp == null) {
+    return '-';
+  }
+  return dayjs(timestamp).format(DATETIME_FORMAT);
+};
+
 export const parseDateStringToDate = (dateString: Date) => {
   return dayjs(dateString).toDate();
 };