Fix ffmpeg_reader not selecting a default stream #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bzczb Thanks for the submission – I don't have time to review its actual contents, but saw it didn't pass the formatting checks. Could you update the formatting? |
|
@keikoro formatting fixed. Can't get pre-commit setup in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #869 #899
ffmpeg, at least the version that's installed automatically with moviepy, sometimes comes up with no default stream for a given input file. This PR does nothing more than set a default stream automatically when none is specified, which is the cause of the missing "video_fps" issue.
Unfortunately I fixed this bug a long time ago in a working branch, and can't find the file that raised this problem in the first place. I think it was a ".wmv" or ".asf".