Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified data tracker access and improved compatibility #11

Merged
merged 1 commit into from
May 14, 2023

Conversation

Nillo-Code
Copy link
Contributor

Prompted from samolego/Taterzens#132 mod compatibility issue.

With the existing pattern SPELL_ENGINE_SYNCED_EFFECTS was causing an id collision. By extending Entity and directly accessing the data tracker, rather than casting this and using methods, the issue was resolved

@ZsoltMolnarrr
Copy link
Owner

This PR seems to solve the issue in a deterministic way.
I still don't understand why. Maybe the conflicting mod overrides the getDataTracker method hence direct access helps.

After testing it looks like this change has no negative effect.
Thank you for the contribution!

@ZsoltMolnarrr ZsoltMolnarrr merged commit 29c594a into ZsoltMolnarrr:1.19.2 May 14, 2023
@samolego
Copy link

Yeah, Taterzens do override getDataTracker due to serveside mod syncing ... Wasn't really aware it'd cause issues

@RockZe
Copy link

RockZe commented May 18, 2023

hah, after reading this report, I didn't understand anything 😅
As far as I understand, an ordinary user cannot solve this problem, and you need to dig deeper and change the mod/mods itself?

@ZsoltMolnarrr
Copy link
Owner

The fix will be published within a few days. :)

@DEAFG0AT
Copy link

DEAFG0AT commented Aug 1, 2023

The fix will be published within a few days. :)

Hey, I'm still having this error on 1.19.2! Did this fix ever get published?
My Spell Engine version is 0.9.25 and Taterzen's is 1.11.1

@Nillo-Code
Copy link
Contributor Author

I can confirm that it has been published and is working with the latest versions, are you sure it is these mods causing the issue?

@ZsoltMolnarrr
Copy link
Owner

The fix has been published long time months ago.
We even figured out why it is working. Tatarzen seemd to override some method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants