Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/nullifier #99

Closed
wants to merge 3 commits into from
Closed

Fix/nullifier #99

wants to merge 3 commits into from

Conversation

neithanmo
Copy link
Contributor

@neithanmo neithanmo commented Jul 17, 2024 •
edited by zboto bot
Loading

  • make log function easier to use
  • Fix note commitment computation
  • add a nullifier test that use the fix to check we get the same nullifier as zcash for the same input data
  • TODO: Add a test to check if note commitment is correct using a reference implementation like zcash

🔗 zboto Link

@neithanmo neithanmo requested review from emmanuelm41 and jleni July 17, 2024 18:14
@neithanmo neithanmo closed this Jul 18, 2024
@emmanuelm41 emmanuelm41 deleted the fix/nullifier branch July 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 Awaiting requested review from emmanuelm41

@jleni jleni Awaiting requested review from jleni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@neithanmo