Fix HDPath validation in recovery app #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
reviewed
Dec 13, 2024
app/src/substrate/substrate_coin.h
Outdated
| @@ -21,13 +21,14 @@ extern "C" { | |||
|
|
|||
| #define COIN_ADDR_TYPE 42 | |||
| #define CLA 0xbc | |||
| #define CLA_RECOVERY 0x90 | |||
There was a problem hiding this comment.
Is this CLA agreed with the team? I don't remember seen it before. I may be wrong, just double checking
There was a problem hiding this comment.
I see now this is the polkadot CLA.... I am not so sure about this... it is not really the polkadot generic app...
There was a problem hiding this comment.
Should the prefix be 0 in these cases where we are using the polkadot path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.