firefox compatibility adjustments #77
Conversation
small adjustments for firefox compatibility
|
these are only preparations to hande different browsers that should otherwise have no consequences |
extension/js/compatibility.js
Outdated
There was a problem hiding this comment.
maps firefox specific API to chrome api naming for example browser.storage.local.get to chrome.storage.local.get
| @@ -76,6 +76,7 @@ class AboutDialog { | |||
| <img src="${chrome.runtime.getURL('images/AES-logo-128.png')}"> | |||
| <h2>AirlineSim Enhancement Suite</h2> | |||
| <p>Version ${version}</p> | |||
| <p>Browser ${window.navigator.userAgent}<p> | |||
There was a problem hiding this comment.
What’s your motivation for putting the userAgent string in the AES about screen?
There was a problem hiding this comment.
was for debug purposes if someone sends you a bug report on discord you have the AES version and exact browser version right there, in case there are browser-specific problems
if it bothers you, it can also be removed/shortened or moved elsewhere or hidden behind a "debug information" button or something
make site load detection more robust by checking for readystate=complete because the load event might get missed fix data saving by not saving methods in database, makes no sense doing so? ZoeBijl#5
…olin/airlinesim-enhancement-suite into firefox-compatibility
fix: small adjustments for firefox compatibility
#5