Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance EarningsTracker with time buckets and primary volume #230

Closed
wants to merge 18 commits into from

Conversation

ksedgwic
Copy link
Collaborator

@ksedgwic ksedgwic commented Aug 15, 2024

This PR moved to #231, wrong branch here, apologies ...

ksedgwic added 18 commits August 9, 2024 13:12
This makes it easier to generate test cases by using literal JSON.
This makes it easier to write test cases by comparing to expected values
…tracker

A time source is needed for upcoming time buckets change.
This commit modifies the schema of EarningsTracker to allow storing
and accessing earning and expenditure data in specific time ranges.

All existing strategies and reports still use all data from all time
so this PR should not change any balancing behavior.

After we've run w/ this for a while we'll have time-based data
collected and can evaluate how to improve the strategies.
…racker

Addresses ([ZmnSCPxj#229])

This allows effective feerates (PPM) to be computed for earnings and
expenses.

This PR updates the schema automatically.  Downgrading to previous
will require manual DB migration (but is possible).
The previous setup was not regenerating commit_hash.h correctly when
the dev tree was modified by git operations.
@ksedgwic ksedgwic marked this pull request as ready for review August 17, 2024 17:43
@ksedgwic
Copy link
Collaborator Author

Replaced by #231

@ksedgwic ksedgwic closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant