-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] seeds: update the seeds list #208
Conversation
Signed-off-by: Vincenzo Palazzo <[email protected]>
00177ba
to
caf48bc
Compare
The list of seeds that we currently have is really old and also are really random. What I did is to peak some of the most popular nodes (including some CLN nodes) and update our list of seeds. However, I am open to an objection is some of you want to keep ar add others seeds nodes. Signed-off-by: Vincenzo Palazzo <[email protected]>
caf48bc
to
454c557
Compare
We had some ideas in #182, but this will surely do as well.
Mostly evil-corp. But oh well. :) |
Yeah, you are right, but these nodes are just used for the first-time connection to start fetching gossip, so I think it would be good to have some nodes that will always be there. In the past, CLBOSS was opening connections with inactive nodes, which is a bit problematic. However, I am very hopeful to add nodes that are maintained by us to contribute to decentralization. I was looking for the node of @chrisguida, but I was not able to find it. Well, maybe I can just look by alias. :-P |
@vincenzopalazzo thank you for adding this, let's test and merge it! It looks like there is a DNS-based connection finder: Would be lovely to get this working we can dynamically update the list w/o pushing releases. |
Is it possible to have a testnet seed list as well? |
Do you think that these seeds are update and it is maintained by someone? |
I suppose one of us could run lseed on testnet |
iirc also the mainet one are unstable, but not sure I never use those |
Maybe we should run some mainnet ones too xD |
At some point, someone should take action, but in my opinion, these seeds should not be managed by a single person. This seems more like a task for a non-profit organization, especially given the current regulatory challenges. |
Well anyway here it is, if anyone wants to try running it. I might give it a shot soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, had some trouble w/ the testnet entries, commented w/ some additional ones that work for me ...
, { "039fbf81305e417c2acbe3b96a4929ce40b7f3537720199db9dc010b1be3c28553:167.99.21.222:19735" | ||
, "030b686a163aa2bba03cebb8bab7778fac251536498141df0a436d688352d426f6:65.108.246.14:19735" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two didn't connect for me ... should they have @
instead of :
? They didn't connect when I tried that replacement either though. I saw:
cln@demo1:~$ lightning-cli --testnet connect 039fbf81305e417c2acbe3b96a4929ce40b7f3537720199db9dc010b1be3c28553@167.99.21.222:19735
{
"code": 401,
"message": "All addresses failed: 167.99.21.222:19735: Connection establishment: Connection refused. ho7qwtwipx7z6ocyena27hu5ztd6rj4t2qygxmbw4xkbr7qhfebeh5yd.onion:19735: need a proxy. "
}
for both (with the replacement)
, { "039fbf81305e417c2acbe3b96a4929ce40b7f3537720199db9dc010b1be3c28553:167.99.21.222:19735" | ||
, "030b686a163aa2bba03cebb8bab7778fac251536498141df0a436d688352d426f6:65.108.246.14:19735" | ||
, "03781444afe27babf724304c25370f195d9d955065d7894539ed7db5fe596badb8@138.197.57.50:19735" | ||
, "021713d5331898c206b57c4f7d40635079de9a97d97782646f31dac18a53f2d979@66.241.124.221:9735" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got impatient waiting for this one and killed the attempt.
, "03e84a109cd70e57864274932fc87c5e6434c59ebb8e6e7d28532219ba38f7f6df@139.144.22.237:9735" | ||
, "03f060953bef5b777dc77e44afa3859d022fc1a77c55138deb232ad7255e869c00@212.46.38.66:9735" | ||
, "036497fee1a0b963a63f0b4374819d9016fcca9c09dbef4cb427a2d0146649b025@44.234.48.207:9735", | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three worked plus the one above
, { Boss::Msg::Network_Testnet | ||
, { "039fbf81305e417c2acbe3b96a4929ce40b7f3537720199db9dc010b1be3c28553:167.99.21.222:19735" | ||
, "030b686a163aa2bba03cebb8bab7778fac251536498141df0a436d688352d426f6:65.108.246.14:19735" | ||
, "03781444afe27babf724304c25370f195d9d955065d7894539ed7db5fe596badb8@138.197.57.50:19735" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this worked
, "03f060953bef5b777dc77e44afa3859d022fc1a77c55138deb232ad7255e869c00@212.46.38.66:9735" | ||
, "036497fee1a0b963a63f0b4374819d9016fcca9c09dbef4cb427a2d0146649b025@44.234.48.207:9735", | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 6 all just worked for me:
028ec70462207b57e3d4d9332d9e0aee676c92d89b7c9fb0850fc2a24814d4d83c@71.171.123.161:9735
02eadbd9e7557375161df8b646776a547c5cbc2e95b3071ec81553f8ec2cea3b8c@18.118.231.3:9735
02312627fdf07fbdd7e5ddb136611bdde9b00d26821d14d94891395452f67af248@23.237.77.12:9735
02889be42fc32093d2dcbfa59369df262e3577b333d8a45e5859dcdd6a4139839a@[2a09:8280:1::42:a6f3]:9735
031c64a68e6d1b9e50711336d92b434c584ce668b2fae59ee688bd73713fee1569@186.154.207.228:9735
038863cf8ab91046230f561cd5b386cbff8309fa02e3f0c3ed161a3aeb64a643b9@203.132.94.196:9735
Maybe just strike the ones that don't work from the list and add the 6 above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully these are somewhat reliable! I guess we can always revisit in a few months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review guys, I will update today the PR
Do you think that we are able to have a small script that will ping the nodes and make sure they are up?
We could inject them inside the CI. IIRC @tsjk has a nice script that we can modify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincenzopalazzo great idea! Then we can be alerted when they are no longer reliable.
@vincenzopalazzo is this ready? anything more than rebase needed? |
I can make a followup PR, currently this PR is making already an impact, as you suggested to me on matrix we can move forward and merge it |
The list of seeds that we currently have is really old
and also are really random.
What I did is to peak some of the most popular nodes (including some CLN
nodes) and update our list of seeds.
However, I am open to an objection is some of you want to keep ar add others
seeds nodes.