-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tor engine Android test #2268
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,389 @@ | |||
package io.bluewallet.bluewallet.tor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has been extracted from Library's Sample file https://github.com/05nelsonm/kmp-tor/blob/1.x.x/samples/kotlin/android/src/main/java/io/matthewnelson/kmp/tor/sample/kotlin/android/SampleApp.kt
@@ -0,0 +1,138 @@ | |||
package app.zeusln.zeus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has been extracted from Robosats' app https://github.com/RoboSats/robosats/blob/main/mobile/android/app/src/main/java/com/robosats/modules/TorModule.java
break; | ||
} | ||
}; | ||
await TorMobile.start(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept it because of the previous implementation, but this is not required to be here, it can be called just if the boolean enableTor
configuration changes.
With this new engine, if a request is sent while starting, it'll be enqueued and if the app goes to background it won't be necessary to start it again.
1c682d4
to
2068ca3
Compare
Description
This is a POC for including a new Tor engine that is being used by Samourai's Sentinel and Robosats' app.
I implemented a simple POC only for Android, to be able to show how the code looks like. The library is https://github.com/05nelsonm/kmp-tor/tree/master, the iOS compatibility is about to be released in v2.
Happy to answer questions and discuss potential issues or improvements :)
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: