Incremental routing code refactoring (1) #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pushes a series of internal code refactoring based on Oliver's routing-refactor branch.
std::borrow::Cow
is rewritten asCow
for readability.send_to_first and
send_to_many`. It reduces the macro processing a bit.NodeId
,FaceId
andNodeIndex
instead ofusize
for index numbers. It improves readability and avoids accidental misusage.Face
. They are wrapped toArc
instead.Face: Borrow<Arc<FaceState>>
.Node::links
is changed fromVec
toHashSet
to speed up.contains()
search.More incremental changes will be pushed later. Before it happens, we'd make sure these changes are correctly done.