refactor: remove KeyExpr::with_parameters

See eclipse-zenoh/zenoh#979
ZettaScaleLabs · Apr 25, 2024 · 0353934 · 0353934
1 parent 433907f
commit 0353934
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/src/key_expr.rs b/src/key_expr.rs
@@ -67,11 +67,6 @@ impl KeyExpr {
         self.0.concat(&other).into_pyres().map_into()
     }
 
-    // TODO https://github.com/eclipse-zenoh/zenoh/pull/974
-    fn with_parameters(&self, parameters: String) -> Selector {
-        self.0.clone().with_owned_parameters(parameters).into()
-    }
-
     // Cannot use `#[pyo3(from_py_with = "...")]`, see https://github.com/PyO3/pyo3/issues/4113
     fn __eq__(&self, other: &Bound<PyAny>) -> PyResult<bool> {
         Ok(self.0 == Self::from_py(other)?.0)

diff --git a/zenoh/__init__.pyi b/zenoh/__init__.pyi
@@ -371,8 +371,6 @@ class KeyExpr:
         You should probably prefer KeyExpr::join as Zenoh may then take advantage of the hierachical separation it ins  erts.
         """
 
-    def with_parameters(self, parameters: str) -> Selector: ...
-
 _IntoKeyExpr = KeyExpr | str
 
 @final
-Original file line number
+Diff line change
@@ Expand Up / @@ -371,8 +371,6 @@ class KeyExpr: @@
             You should probably prefer KeyExpr::join as Zenoh may then take advantage of the hierachical separation it ins  erts.
             """
-        def with_parameters(self, parameters: str) -> Selector: ...
     _IntoKeyExpr = KeyExpr | str
     @final
@@ Expand Down @@