Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): Verify consensus branch ID before SIGHASH computation #9139

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jan 18, 2025

Motivation

Close #9089.

Specifications & References

Solution

  • TBD

Tests

  • Add tests that check that tx verification fails when a tx attempts to use an invalid consensus branch id for its SIGHASH.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tx verifier does not enforce using the correct consensus branch ID in the SIGHASH computation
2 participants