Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize CMake files #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

modernize CMake files #11

wants to merge 1 commit into from

Conversation

UI233
Copy link

@UI233 UI233 commented May 5, 2023

I have rewritten the CMakeLists files to make them fit the modern cmake pattern. Generally, it can bring about the following advantages compared to legacy cmake:

  • More user-friendly for external users, users can now link the interface library easily using cmake package manager like Fetch or CPM.
  • Modulize the package so that variables and compile definitions would not populate other scopes.
  • Make this project easier to extend in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant