Support async iteration #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alubbe
commented
Jun 8, 2020
| @@ -0,0 +1,35 @@ | |||
| const {once} = require('events'); | |||
There was a problem hiding this comment.
this file is the same helper as used (and tested) in the exceljs code base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fully functioning async iteration (see #191)
I would love to add a test case for this that goes through a real zip file, does some async things, and then breaks the loop. But, it would need to be done in a way that the test case only runs on node v12 and above. With the current setup of
tap test/*.js --jobs=10 --coverage-report=html --no-browserI'm not sure how/where to do that - any suggestions?