Merge pull request #138 from rtritto/fix-xvfb-dep

Change xvfb as optional peer dependency

lib/cjs/index.js

@@ -1,6 +1,11 @@
-var puppeteer = require("rebrowser-puppeteer-core");
+const puppeteer = require("rebrowser-puppeteer-core");
 const { pageController } = require("./module/pageController.js");
-const Xvfb = require("xvfb");
+let Xvfb
+try {
+  Xvfb = require("xvfb");
+} catch {
+  // ignore
+}
 
 async function connect({
   args = [],

lib/esm/index.mjs

@@ -1,7 +1,6 @@
 import { launch, Launcher } from "chrome-launcher";
 import puppeteer from "rebrowser-puppeteer-core";
 import { pageController } from "./module/pageController.mjs";
-import Xvfb from "xvfb";
 
 // process.env.REBROWSER_PATCHES_DEBUG=1
 export async function connect({
@@ -20,6 +19,7 @@ export async function connect({
 
   if (process.platform === "linux" && disableXvfb === false) {
     try {
+      const { default: Xvfb } = await import("xvfb");
       xvfbsession = new Xvfb({
         silent: true,
         xvfb_args: ["-screen", "0", "1920x1080x24", "-ac"],

package.json

@@ -42,9 +42,19 @@
     "ghost-cursor": "^1.3.0",
     "puppeteer-extra": "^3.3.6",
     "rebrowser-puppeteer-core": "^23.3.1",
-    "tree-kill": "^1.2.2",
+    "tree-kill": "^1.2.2"
+  },
+  "devDependencies": {
     "xvfb": "^0.4.0"
   },
+  "peerDependencies": {
+    "xvfb": "*"
+  },
+  "peerDependenciesMeta": {
+    "xvfb": {
+      "optional": true
+    }
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/zfcsoftware/puppeteer-real-browser"