Enable LUT selection for emodulus computation in analysis view #166
Conversation
shapeout2/gui/analysis/ana_slot.py
Outdated
| self.comboBox_visc_model.setVisible(medium_key.count("MC-PBS")) | ||
| self.comboBox_lut.setVisible(medium_key.count("MC-PBS")) |
There was a problem hiding this comment.
I don't know whether we need this. I just followed the comboBox_visc_model implementation.
There was a problem hiding this comment.
The viscosity model is only applicable for MC-PBS, whereas the LUT selection is universal. So no, we must not hide the LUT selection if the buffer is set to MC-PBS.
There was a problem hiding this comment.
Thanks for letting me know.
|
Hi @paulmueller |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 79.22% 79.26% +0.04%
==========================================
Files 64 64
Lines 6974 6988 +14
==========================================
+ Hits 5525 5539 +14
Misses 1449 1449 ☔ View full report in Codecov by Sentry. |
shapeout2/gui/analysis/ana_slot.py
Outdated
| @@ -143,6 +145,9 @@ def __setstate__(self, state): | |||
| # use defaults from previous session (Herold-2107) | |||
| idx_vm = 1 | |||
| self.comboBox_visc_model.setCurrentIndex(idx_vm) | |||
| # Set current state of the emodulus lut | |||
| idx_lut = self.comboBox_lut.findText(emodulus.get("emodulus lut", "")) | |||
There was a problem hiding this comment.
Just a comment: For now, this is fine, because it follows the current code. But in general, using Data instead of Text is cleaner, because text might be subject to internationalization: #167
shapeout2/gui/analysis/ana_slot.py
Outdated
| self.comboBox_visc_model.setVisible(medium_key.count("MC-PBS")) | ||
| self.comboBox_lut.setVisible(medium_key.count("MC-PBS")) |
There was a problem hiding this comment.
The viscosity model is only applicable for MC-PBS, whereas the LUT selection is universal. So no, we must not hide the LUT selection if the buffer is set to MC-PBS.
|
Hi @paulmueller , |
This PR aims to implement the selection of LUT in the analysis view. This is mentioned as a second point in the issue #71.