Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: replace QComboBox.findText with QCombobox.findData #167

Open
paulmueller opened this issue Sep 23, 2024 · 0 comments
Open

ref: replace QComboBox.findText with QCombobox.findData #167

paulmueller opened this issue Sep 23, 2024 · 0 comments
Labels
good first issue Good for new contributors refactoring No functional changes, just cleanup

Comments

@paulmueller
Copy link
Member

Using data instead of text is cleaner programming style. This seems to only affect UI related to computation of Young's modulus.
@paulmueller paulmueller added refactoring No functional changes, just cleanup good first issue Good for new contributors labels Sep 23, 2024
@paulmueller paulmueller mentioned this issue Sep 23, 2024
Merged
@paulmueller paulmueller changed the title ref: replace QCombnoBox.findText with QCombobox.findData ref: replace QComboBox.findText with QCombobox.findData Sep 23, 2024
@RaghavaAlajangi RaghavaAlajangi mentioned this issue Oct 2, 2024
Merged
paulmueller pushed a commit that referenced this issue Oct 2, 2024
@RaghavaAlajangi
enh: replace findText with findData of comboBox_visc_model (#169)
828430a 
Partial #167 

---------

Co-authored-by: NadiaSbaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for new contributors refactoring No functional changes, just cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmueller @RaghavaAlajangi