Enable linter and fix the issues pointed out by it

Signed-off-by: Yutaro Hayakawa <[email protected]>

.github/workflows/golangci-lint.yaml

@@ -0,0 +1,28 @@
+name: golangci-lint
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: ./go.mod
+
+      - name: Lint
+        uses: golangci/golangci-lint-action@v5
+        with:
+          version: latest
+          args: -D errcheck

Makefile

@@ -4,6 +4,9 @@ DEEPCOPY_OPTS=-type Config -type InterfaceConfig -type InterfaceStatus
 
 all:
 
+lint:
+	docker run -t --rm -v $(PWD):/app -w /app golangci/golangci-lint:v1.58.0 golangci-lint run -v -D errcheck
+
 deepcopy:
 	deep-copy -pointer-receiver $(DEEPCOPY_OPTS) -o zz_generated_deepcopy.go .
 

daemon.go

@@ -12,7 +12,6 @@ import (
 type Daemon struct {
 	initialConfig     *Config
 	reloadCh          chan *Config
-	stopCh            any
 	logger            *slog.Logger
 	socketConstructor rAdvSocketCtor
 

fake_socket.go

@@ -76,10 +76,6 @@ func (s *fakeSock) txCh() <-chan fakeRA {
 	return s.tx
 }
 
-func (s *fakeSock) rxCh() chan<- fakeRS {
-	return s.rx
-}
-
 func (s *fakeSock) hardwareAddr() net.HardwareAddr {
 	return net.HardwareAddr{0xaa, 0xbb, 0xcc, 0xdd, 0xee, 0xff}
 }

integration_tests/gobgp_unnumbered_test.go

@@ -52,16 +52,16 @@ func TestGoBGPUnnumbered(t *testing.T) {
 	sysctlClient, err := sysctl.NewClient(sysctl.DefaultPath)
 	require.NoError(t, err)
 
-	sysctlClient.Set("net.ipv6.conf.go-radv0.forwarding", "1")
+	err = sysctlClient.Set("net.ipv6.conf.go-radv0.forwarding", "1")
 	require.NoError(t, err)
 
-	sysctlClient.Set("net.ipv6.conf.go-radv0.accept_ra", "2")
+	err = sysctlClient.Set("net.ipv6.conf.go-radv0.accept_ra", "2")
 	require.NoError(t, err)
 
-	sysctlClient.Set("net.ipv6.conf.go-radv1.forwarding", "1")
+	err = sysctlClient.Set("net.ipv6.conf.go-radv1.forwarding", "1")
 	require.NoError(t, err)
 
-	sysctlClient.Set("net.ipv6.conf.go-radv1.accept_ra", "2")
+	err = sysctlClient.Set("net.ipv6.conf.go-radv1.accept_ra", "2")
 	require.NoError(t, err)
 
 	t.Log("Sysctl set. Starting radvd.")

ra_sender.go

@@ -31,11 +31,6 @@ type raSender struct {
 	socketCtor rAdvSocketCtor
 }
 
-type raSenderStatusReq struct {
-	ctx   context.Context
-	resCh chan *InterfaceStatus
-}
-
 func newRASender(initialConfig *InterfaceConfig, ctor rAdvSocketCtor, logger *slog.Logger) *raSender {
 	return &raSender{
 		logger:        logger.With(slog.String("interface", initialConfig.Name)),
@@ -164,6 +159,7 @@ reload:
 				}
 				config = newConfig
 				s.reportReloading()
+				s.resetStat()
 				s.setLastUpdate()
 				continue reload
 			case <-ctx.Done():

socket.go

@@ -11,10 +11,6 @@ import (
 	"golang.org/x/net/ipv6"
 )
 
-const (
-	maxRecvSize = 1500
-)
-
 // rAdvSocket is a raw socket for sending RA and receiving RS
 type rAdvSocket interface {
 	hardwareAddr() net.HardwareAddr