Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Wrong warning runtime ram missing during upgrade #1971

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[fix] Wrong warning runtime ram missing during upgrade #1971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2881,12 +2881,22 @@ def _check_manifest_requirements(
# Is "include_swap" really useful ? We should probably decide wether to always include it or not instead
if ram_requirement.get("include_swap", False):
ram += swap

# During upgrade build operations, the service is stopped
can_build = ram_requirement["build"] == "?" or ram > human_to_binary(
ram_requirement["build"]
) or (
action == "upgrade" and
ram_requirement["runtime"] != "?" and
ram + human_to_binary(ram_requirement["runtime"]) > human_to_binary(ram_requirement["build"])
)

# Before upgrading, the application is probably already running,
# and RAM rarely increases significantly from one version to the next.
# FIXME: during upgrade compare old ram runtime with the new one
can_run = ram_requirement["runtime"] == "?" or ram > human_to_binary(
ram_requirement["runtime"]
)
) or action == "upgrade"

# Some apps have a higher runtime value than build ...
if ram_requirement["build"] != "?" and ram_requirement["runtime"] != "?":
Expand All @@ -2896,8 +2906,10 @@ def _check_manifest_requirements(
> human_to_binary(ram_requirement["runtime"])
else ram_requirement["runtime"]
)
else:
elif ram_requirement["build"] != "?":
max_build_runtime = ram_requirement["build"]
else:
max_build_runtime = ram_requirement["runtime"]

yield (
"ram",
Expand Down
Loading