Print meaningful object graph for Unity components #10
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbergen
reviewed
Jan 22, 2025
| if (transform.name.EndsWith("(Clone)")) | ||
| { | ||
| // Stop printing when we find an instantiated object, we are validating that prefab | ||
| result.AppendLine(transform.name.Replace("(Clone)", " (prefab)")); |
There was a problem hiding this comment.
I'm not sure if this will work with WithGameObjectName (it would overwrite the default name with "(Clone)"), but I guess it's not very critical.
There was a problem hiding this comment.
Yes, it'd print the whole hierarchy all the way to SceneContext but I think that's okay.
sbergen
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object graph used to be just a one-liner in many cases:
Now when prefabs are being validated, it will look like this:
This makes it clear which component in which prefab failed the validation, which is especially useful for reusable components.