hotfix(MetricReporting.scala): reportLagTime_on_empty_dataframe (#354)

YotpoLtd · Aug 9, 2020 · 042a106 · 042a106
1 parent 5a0e2cc
commit 042a106
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/main/scala/com/yotpo/metorikku/metric/MetricReporting.scala b/src/main/scala/com/yotpo/metorikku/metric/MetricReporting.scala
@@ -38,10 +38,15 @@ class MetricReporting {
   def reportLagTime(dataFrame: DataFrame, reportLagTimeColumn: Option[String],
                     reportLagTimeColumnUnits:Option[String],
                     instrumentationProvider: InstrumentationProvider) : Unit ={
-    val maxDataframeTime = getMaxDataframeTime(dataFrame, reportLagTimeColumn, reportLagTimeColumnUnits)
-    log.info(s"Max column ${reportLagTimeColumn} value is ${maxDataframeTime} for ${dataFrame}")
-    val lag = System.currentTimeMillis - maxDataframeTime
-    log.info(s"Reporting lag value: ${lag} for ${dataFrame}")
-    instrumentationProvider.gauge(name = "lag", lag)
+    dataFrame.isEmpty match {
+      case false => {
+        val maxDataframeTime = getMaxDataframeTime(dataFrame, reportLagTimeColumn, reportLagTimeColumnUnits)
+        log.info(s"Max column ${reportLagTimeColumn} value is ${maxDataframeTime} for ${dataFrame}")
+        val lag = System.currentTimeMillis - maxDataframeTime
+        log.info(s"Reporting lag value: ${lag} for ${dataFrame}")
+        instrumentationProvider.gauge(name = "lag", lag)
+      }
+      case true => instrumentationProvider.gauge(name = "lag", 0)
+    }
   }
 }