Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the age in meta tag descriptions #114

Closed

Conversation

Keerthivardhan1
Copy link
Contributor

@Keerthivardhan1 Keerthivardhan1 commented Oct 22, 2022

Purpose

hear the issue is to change the age in the index.html files
The purpose of this Pull Request is to fix #76

Goals

as per the issue the goal is to change the age 13 to 14 in all index.html file

Approach

step1: clone the repo
step2: read README file and understand code structure of the project .
step3: change the age from 13 to 14 in the all index.html files that are the project.
step4: add and commit the changes and push your branch.

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Chrome
Version 106.0.5249.119 (Official Build) (64-bit)

Learning

by understanding the project I learnt how to structure our code and divide in to categories

@YoshithaRathnayake YoshithaRathnayake changed the title age in the /light/index.html file is updated Update the age in meta tag descriptions Oct 22, 2022
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The age in the Facebook OG meta tag description's age in index.html file is 1 years old. @Keerthivardhan1

image

Change the age in it to 14 years old.

Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the Preview Link section in the pr template @Keerthivardhan1

Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the screenshots section from the pr template @Keerthivardhan1

Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The age in the light/index.html file Facebook OG meta tag description's age is still 13 years old.

image

Change it to 14 years old @Keerthivardhan1

@Keerthivardhan1
Copy link
Contributor Author

done

@YoshithaRathnayake YoshithaRathnayake added invalid This doesn't seem right wontfix This will not be worked on labels Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change my age to 14 in the meta tag descriptions
2 participants