Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the languages that I am using to contact section #106

Closed
wants to merge 5 commits into from
Closed

Add the languages that I am using to contact section #106

wants to merge 5 commits into from

Conversation

Hiresh23
Copy link

@Hiresh23 Hiresh23 commented Oct 15, 2022 •
edited
Loading

Purpose

To add languages and icon
#89

Goals

People can know in which languages they can contact

Approach

Just add a section in which a paragraph tag is used for text and image tag for logo

Screenshots

Screenshot 2022-10-15 120711

Preview Link

https://pr-106-new-yoshitha-website.surge.sh/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

YoshithaRathnayake
YoshithaRathnayake requested changes Oct 15, 2022
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the topic of this pr as the topic of the issue

YoshithaRathnayake
YoshithaRathnayake requested changes Oct 15, 2022
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the preview link as this https://pr-106-new-yoshitha-website.surge.sh/

YoshithaRathnayake
YoshithaRathnayake requested changes Oct 15, 2022
View reviewed changes
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the issue number in the purpose don't put it in <> tags

@Hiresh23 Hiresh23 changed the title Change2 Add the languages that I am using to contact section Oct 15, 2022
@Hiresh23
Copy link
Author

Done

YoshithaRathnayake
YoshithaRathnayake requested changes Oct 15, 2022
View reviewed changes
dark/assets/css/styles.css
@@ -923,3 +931,28 @@ html {
bottom: -26px;
left: calc(50% - 20px);
}

#contact-section .context1{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these early commits

YoshithaRathnayake
YoshithaRathnayake requested changes Oct 15, 2022
View reviewed changes
dark/index.html
@@ -231,6 +231,13 @@ <h3>ABOUT <span class="text-info">ME</span></h3>
<section id="contact-section">
<h1>CONTACT ME</h1>
<h3>CONTACT <span class="text-info">ME</span></h3>
<section class="context1"><p>Want to get in touch with me? Fill out the form with your inquiry or mail me,you can also connect with me on social media platforms on above given links</p>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these early commits

@YoshithaRathnayake YoshithaRathnayake added invalid This doesn't seem right spam Spammy labels Oct 19, 2022
@Hiresh23
Copy link
Author

Bro please remove spam

@Hiresh23
Copy link
Author

I would work on the website my exam were going so i could not do

@YoshithaRathnayake YoshithaRathnayake added wontfix This will not be worked on and removed spam Spammy labels Oct 21, 2022
@Hiresh23
Copy link
Author

too late i have been disqualified because of you

@YoshithaRathnayake
Copy link
Owner

too late i have been disqualified because of you

So you should have tell it to me early

@YoshithaRathnayake
Copy link
Owner

too late i have been disqualified because of you

If you want create a new github account and do hacktobefest no worries.

@YoshithaRathnayake
Copy link
Owner

too late i have been disqualified because of you

create new account I will help you @Hiresh23

@YoshithaRathnayake
Copy link
Owner

too late i have been disqualified because of you

don't tell me bcs of you bcs you should have tell it to me early like I am having exams so I can't do this. If you told like that I won't put the spam label @Hiresh23

@YoshithaRathnayake
Copy link
Owner

too late i have been disqualified because of you

don't tell me bcs of you bcs you should have tell it to me early like I am having exams so I can't do this. If you told like that I won't put the spam label @Hiresh23

I don't know no you reason what are you not doing so should tell it to me otherwise I will put spam label

@YoshithaRathnayake YoshithaRathnayake added spam Spammy and removed wontfix This will not be worked on labels Oct 22, 2022
@YoshithaRathnayake
Copy link
Owner

If you disqualified or if you have exams they both are same bcs if its disqualified you can't do hacktoberfest, if you face your exams you won't be able to do hacktoberfest so no need to worry about this how ever you won't be able to do hacktoberfest @Hiresh23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshithaRathnayake YoshithaRathnayake YoshithaRathnayake requested changes

Assignees
No one assigned
Labels
invalid This doesn't seem right spam Spammy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hiresh23 @YoshithaRathnayake