Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

row indices of NA observations in error message #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

idot
Copy link

@idot idot commented Jan 31, 2018

adds indices of genes failing filtering to error message

adds indices of genes failing filtering to error message
@drisso
Copy link
Contributor

drisso commented May 6, 2021

Hi @idot ,

thanks for the PR and sorry for not responding earlier, I hope this is still relevant and you are still willing to contribute.

Your PR would not work if pos_controls is a character vector. Can you please edit it so that it would? Also, it would be good to avoid 1:nrow(expr) and use seq_len(nrow(expr)) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants