Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All zero check #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

All zero check #41

wants to merge 4 commits into from

Conversation

LevyNat
Copy link

@LevyNat LevyNat commented Oct 14, 2024

In the Hotspot init, there is a check to ensure that a gene is not 'all zero'. i..e. never expressed in any cell.

It checks that the sum of its expression over all cells is greater than 0, which makes sense if we consider NB or Bernoulli data; but if we have 'normal' or 'none' (meaning no assumption about data distribution but assuming data is already standardized) one can get negative or zero sums. For instance this is the case if one wants to compute the autocorrelation of module scores, which are PC loadings and real numbers.

Thus I propose to change the valid_genes computation to consider an 'all zero' column iff all elements are zero.

@deto
Copy link
Member

deto commented Oct 15, 2024

Thanks - it makes sense that this check isn't expansive enough. However, the real issue is that the std. deviation for genes that are all 0 is zero and then this leads to nans/infinities later on. Could you change the PR so that instead of checking for all zero, you check to see if the std of the gene == 0? I think that should cover all cases better.

@LevyNat
Copy link
Author

LevyNat commented Oct 20, 2024

Thanks @deto, I updated to check if a gene row is constant, which means it has 0 std.

In addition there is a warning for the use of a sparse matrix different from csr format but the warning text said we should use a csc matrix. I updated to csr, is it correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants