Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dtype checking in local plotting #167

Closed
wants to merge 7 commits into from
Closed

Fix dtype checking in local plotting #167

wants to merge 7 commits into from

Conversation

Lioscro
Copy link
Collaborator

@Lioscro Lioscro commented Jan 31, 2022 •
edited
Loading

Branched from #164

@Lioscro Lioscro self-assigned this Jan 31, 2022
@Lioscro Lioscro changed the base branch from master to bam-group-by-speedup January 31, 2022 23:29
@codecov
Copy link

codecov bot commented Jan 31, 2022 •
edited
Loading

Codecov Report

Patch coverage: 92.15% and project coverage change: -0.01% ⚠️

Comparison is base (03198eb) 78.82% compared to head (6f595b1) 78.82%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   78.82%   78.82%   -0.01%     
==========================================
  Files          88       88              
  Lines        7782     7800      +18     
==========================================
+ Hits         6134     6148      +14     
- Misses       1648     1652       +4
Files Changed Coverage Δ
cassiopeia/preprocess/cassiopeia_preprocess.py 21.81% <0.00%> (-1.26%) ⬇️
cassiopeia/preprocess/pipeline.py 91.15% <ø> (ø)
cassiopeia/plotting/local.py 80.30% <50.00%> (-0.32%) ⬇️
cassiopeia/preprocess/UMI_utils.py 94.71% <100.00%> (+0.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lioscro Lioscro marked this pull request as ready for review May 18, 2022 14:02
@Lioscro Lioscro requested a review from sprillo June 17, 2022 19:32
@colganwi colganwi changed the base branch from bam-group-by-speedup to master August 28, 2023 20:21
@colganwi colganwi requested review from colganwi and removed request for sprillo August 28, 2023 20:23
@colganwi
Copy link
Collaborator

Closing in favor of clean PR #220

@colganwi colganwi closed this Aug 28, 2023
@colganwi colganwi deleted the fix-plotting-dtypes2 branch August 29, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colganwi colganwi Awaiting requested review from colganwi

Assignees

@Lioscro Lioscro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lioscro @colganwi