Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolutionary coupling #154

Merged
merged 14 commits into from
Nov 11, 2021
Merged

Evolutionary coupling #154

merged 14 commits into from
Nov 11, 2021

Conversation

mattjones315
Copy link
Collaborator

@mattjones315 mattjones315 commented Oct 27, 2021

Implements the Evolutionary Coupling statistic.

The main logic is stored in cassiopeia/tools/coupling.py which in the future can store other methods for computing the "couplings" between variables.

Auxiliary functionality is implemented in cassiopeia/data/utilities.py for computing distances between categories.

This will work towards resolving #149

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #154 (da061cd) into master (d13d3e7) will increase coverage by 0.03%.
The diff coverage is 89.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   87.09%   87.13%   +0.03%     
==========================================
  Files          70       71       +1     
  Lines        4821     4880      +59     
==========================================
+ Hits         4199     4252      +53     
- Misses        622      628       +6     
Impacted Files Coverage Δ
cassiopeia/data/__init__.py 100.00% <ø> (ø)
cassiopeia/tools/topology.py 100.00% <ø> (ø)
cassiopeia/data/utilities.py 88.31% <79.16%> (-1.69%) ⬇️
cassiopeia/tools/coupling.py 97.05% <97.05%> (ø)
cassiopeia/tools/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13d3e7...da061cd. Read the comment docs.

@mattjones315 mattjones315 requested a review from sprillo October 27, 2021 21:58
@mattjones315 mattjones315 marked this pull request as ready for review October 27, 2021 22:20
@mattjones315 mattjones315 linked an issue Oct 27, 2021 that may be closed by this pull request
@mattjones315 mattjones315 self-assigned this Oct 28, 2021
@mattjones315 mattjones315 requested review from Lioscro and removed request for sprillo November 9, 2021 16:01
Copy link
Collaborator

@Lioscro Lioscro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple very minor comments.

cassiopeia/data/utilities.py Outdated Show resolved Hide resolved
cassiopeia/tools/coupling.py Outdated Show resolved Hide resolved
@mattjones315 mattjones315 requested a review from Lioscro November 10, 2021 18:53
Copy link
Collaborator

@Lioscro Lioscro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattjones315 mattjones315 merged commit 577bc73 into master Nov 11, 2021
@mattjones315 mattjones315 deleted the evolutionary_coupling branch November 11, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Utilities from KP-Tracer MS
2 participants