Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
When running the tests, three notices along the lines of the below are shown at the top of the test run:
The reason these notices show is that the
blocks/*/*/block.json
files for the Yoast custom blocks do not exist in a plain PHP based test environment in which nonpm install
(etc) has been run.Now why does that cause these notices ?
register_block_type()
function.register_block_type()
function is one of those monstrosities you find in WP - it can be various different data types:To fix this, I've updated the
yoast_seo_create_asset_files
closure which was originally used to only create thesrc/generated/assets
files to also handle creation of mocks for the missingblock.json
files.As the PHP tests don't contain tests which are dependent on the real
block.json
files being in place and valid, this "hack" will side-step the notices from WP without diminishing the value of the tests.Also note that if a dev-user already has (real) copies of these files in their development setup, those files will not be overwritten by this fix, so this shouldn't break anyone's dev environment.
Ref:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps: