Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change admin bar notifications URL #21901

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

igorschoester
Copy link
Member

@igorschoester igorschoester commented Dec 5, 2024

Context

  • Pointing the admin bar notifications link to the alert center instead of the default route (dashboard)

Summary

This PR can be summarized in the following changelog entry:

  • Changes the admin bar notification URL to point to the alert center.
  • Changes the Dashboard' learn more link copy and URL.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Alert center link

  • Ensure you have the admin bar enabled and see Yoast SEO in there
  • Click on the Yoast icon
    ab-icon
  • Verify you went to the Dashboard page: admin.php?page=wpseo_dashboard
  • Hover over the Yoast icon and click on the Notifications
    ab-notifications
  • Verify you went to the Alert center page: admin.php?page=wpseo_dashboard#/alert-center

There is a check for permissions (can manage options), but since it is the same for even having the page I have no clue how to even test that.

Dashboard copy

  • Go to the dashboard
  • Verify the link in the description now has the copy: Learn more about the dashboard
  • Verify the link is https://yoa.st/dashboard-learn-more

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/351
Fixes https://github.com/Yoast/reserved-tasks/issues/352

Pointing to the alert center instead of the default route (dashboard)
@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Dec 5, 2024
@igorschoester igorschoester added this to the 24.1 milestone Dec 5, 2024
Instead of content analysis it is now about the dashboard in general
Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit 829c0ce into release/24.1 Dec 5, 2024
33 checks passed
@thijsoo thijsoo deleted the 351-change-notifications-link-in-menu-bar branch December 5, 2024 14:19
@hardikgohil7988
Copy link

Verified yoast icon and notification in admin bar on dashbaord and alert center pages
Verified learn more link and redirection on dashboard

igorschoester added a commit that referenced this pull request Dec 9, 2024
Changed:
* Learn more link copy
* Learn more link key

This is needed because the original PR: #21898
Was not adjusted after a fix-before-release PR changed copy & key: #21901
yoastbot-ci pushed a commit to Yoast-dist/wordpress-seo that referenced this pull request Dec 9, 2024
Synced up to commit hash: Yoast/wordpress-seo@38680bb

Timestamp last commit: 2024-12-09T10:35:45+01:00

Committer last commit: @igorschoester

Commit message last commit:

---------------------------

Dashboard: adapt page title test

Changed:
* Learn more link copy
* Learn more link key

This is needed because the original PR: Yoast/wordpress-seo#21898
Was not adjusted after a fix-before-release PR changed copy & key: Yoast/wordpress-seo#21901
vraja-pro pushed a commit that referenced this pull request Dec 9, 2024
Changed:
* Learn more link copy
* Learn more link key

This is needed because the original PR: #21898
Was not adjusted after a fix-before-release PR changed copy & key: #21901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants