-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the score API endpoints #21867
Merged
thijsoo
merged 22 commits into
trunk
from
538-add-integration-tests-for-the-api-endpoints
Dec 16, 2024
Merged
Add tests for the score API endpoints #21867
thijsoo
merged 22 commits into
trunk
from
538-add-integration-tests-for-the-api-endpoints
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build de087bc7c7be2665affa71ae02ecfe2b6dbd7f25Details
💛 - Coveralls |
…r-the-api-endpoints
leonidasmi
force-pushed
the
538-add-integration-tests-for-the-api-endpoints
branch
2 times, most recently
from
November 29, 2024 11:06
4743d2c
to
90aa20b
Compare
leonidasmi
force-pushed
the
538-add-integration-tests-for-the-api-endpoints
branch
from
November 29, 2024 11:14
90aa20b
to
47c9ac5
Compare
leonidasmi
force-pushed
the
538-add-integration-tests-for-the-api-endpoints
branch
6 times, most recently
from
December 6, 2024 14:17
cab7f95
to
c9a8a11
Compare
leonidasmi
force-pushed
the
538-add-integration-tests-for-the-api-endpoints
branch
15 times, most recently
from
December 9, 2024 11:10
332eaf2
to
b4fdfdb
Compare
leonidasmi
force-pushed
the
538-add-integration-tests-for-the-api-endpoints
branch
from
December 9, 2024 14:16
b4fdfdb
to
8f5b1fd
Compare
leonidasmi
force-pushed
the
538-add-integration-tests-for-the-api-endpoints
branch
from
December 9, 2024 14:24
8283903
to
2a64b35
Compare
thijsoo
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR + ACC 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Get_Scores_Test
classes, for some reasonTest instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/reserved-tasks/issues/355